Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong use of aria-hidden #346

Closed
mp-horm opened this issue Sep 28, 2023 · 2 comments · Fixed by #434
Closed

Wrong use of aria-hidden #346

mp-horm opened this issue Sep 28, 2023 · 2 comments · Fixed by #434
Labels
🌟 feature request New feature or request

Comments

@mp-horm
Copy link

mp-horm commented Sep 28, 2023

Describe the bug
Carousel items are marked as aria-hidden=true when not visible. Aria-hidden should only be applied to non-interactive elements.
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden
The attribute causes WCAG errors when using focusable elements (buttons, inputs, links) in carousel items.

To Reproduce
Steps to reproduce the behavior:

  1. Render a carousel with two items, one of them using a focusable element (ie a button)
  2. Click on the non-button item
  3. Copy page html to https://validator.w3.org/#validate_by_input
  4. See error related to
    https://accessibilityinsights.io/info-examples/web/aria-hidden-focus/

Expected behavior
No accessibility errors

@kwilfert
Copy link

I second this. During my migration to vue 3, its compatibility mode keeps logging the aria-hidden property's false-value.

@ismail9k ismail9k added 🌟 feature request New feature or request and removed 😐 stale labels Nov 26, 2024
@Tofandel
Copy link
Contributor

I'm also noting that the carousel has a tabindex="0" so it's focusable, but then it does nothing with the focus (like using arrow keys to slide prev and next)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants