Replies: 8 comments 7 replies
This comment has been hidden.
This comment has been hidden.
-
OGP Design System text styles and Isomer Template/Preview text styles differ in font, weight, etc. Hence we are unable to map preview text styles to the OGP design system. As preview is a reflection of the Isomer template and staging, we'd want to ensure that they match as closely as possible, if not identically. Hence, if we are not updating template text styles to match in this refactor, we should not be changing preview text styles to match the rest of the CMS interface since they are at their root, different text styles. Hence, we will create new text styles for preview, based on the current text styles in staging/production (i.e. Isomer template). Figma link for details of the text styles can be found here. *Note: There is currently no documentation for Isomer template typography and text styles, hence we're recreating these based on what is in production on the template. However aside from size, line height and tracking have been calculated based on the OGP design system formula provided. This may cause a slight visual difference between preview (calculated) and template (legacy). However, since these values have now been properly calculated, we should eventually update the template fonts to match these line height and tracking values. **Second note: During this process, we realised that Preview header font weight and staging font weight are different (Bold 700 vs Normal 400), causing a visual discrepancy between the two. As an intermediate solution, we will match all header font weights to staging (Normal 400), but we should definitely push to change these header weights to Bold 700 when we next do a template update. To dos when we next update template:
|
Beta Was this translation helpful? Give feedback.
-
migration will be gradual, so we will have instances where some pages use design system components but others don't. eventually, they should all be in design system but is it acceptable to have it in such a state or should it be all or nothing? also, could i just get a sense of importance for the new components outlined here? i'm inclined to put the cards as p2, with headers/bottom p3 (as the component as-is in isomer is pretty messy). for the modal, if it's just a design refresh, it might be doable but due to how intertwined modals in isomer are with data fetching logic, i'm disinclined to prioritize it @__@ |
Beta Was this translation helpful? Give feedback.
-
List of visual differences between staging/prod
|
Beta Was this translation helpful? Give feedback.
-
@kathleenkhy @NatMaeTan we're not migrating the pages itself so there might be a few differences between v1.5 and the actual look on staging when deployed; will get @NatMaeTan to look thru and see what are some major diffs that we should fix for usability and if required, adjust timeline! |
Beta Was this translation helpful? Give feedback.
-
Release checklist for v1.5DesignProdRollback plan
|
Beta Was this translation helpful? Give feedback.
-
UI & Bug fixes from FE walkthrough 23 June |
Beta Was this translation helpful? Give feedback.
-
Discussion Points
input
,button
anddropdown
. Former two can come from design system butdropdown
is a new component and will be prioritised to avoid blocking design.Beta Was this translation helpful? Give feedback.
All reactions