Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): Support using --all with node.js ES modules #1320

Merged
merged 1 commit into from
May 24, 2020

Conversation

coreyfarrell
Copy link
Member

This allows --all to collect initial coverage from fils which node.js
recognizes as ES modules (.mjs files and conditionally .js files).
Previously this would cause node.js to produce an ERR_REQUIRE_ESM
error.

This does not enable collection of coverage during actual tests, for that
you must use the experimental @istanbuljs/esm-loader-hook.

This allows `--all` to collect initial coverage from fils which node.js
recognizes as ES modules (`.mjs` files and conditionally `.js` files).
Previously this would cause node.js to produce an `ERR_REQUIRE_ESM`
error.

This does not enable collection of coverage during actual tests, for that
you must use the experimental `@istanbuljs/esm-loader-hook`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant