-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nyc@7.0.0-alpha3 lcov report broken #288
Comments
@JaKXz @gotwarlost interestingly enough, works well with the new {
"name": "nyc-ava-test",
"version": "1.0.0",
"description": "",
"main": "say.js",
"scripts": {
"test": "nyc -r lcov ava"
},
"author": "",
"license": "ISC",
"babel": {
"presets": [
"es2015"
],
"plugins": [
"istanbul"
]
},
"nyc": {
"include": [
"*.js"
],
"require": [
"babel-register"
],
"sourceMap": false,
"instrument": false
},
"devDependencies": {
"ava": "^0.15.1",
"babel": "^6.5.2",
"babel-cli": "^6.9.0",
"babel-plugin-istanbul": "^1.0.0",
"babel-preset-es2015": "^6.9.0",
"babel-register": "^6.9.0",
"nyc": "^7.0.0-alpha.3"
}
} underlying problem seems to be bad source-map positions, which I know we've bumped into in a few places. Hopefully this will be fixed once the issue @gotwarlost opened on babel itself is addressed, and once we switch source-map functionality over to using Isanbul directly. If anyone gets bored @novemberborn, @JaKXz, @jamestalmage, would love help wiring up Istanbul's source-maps, such that we can retire nyc's handling of them. |
@kentcdodds this is the same issue you reported :) |
Ok, I thought it might be :-) Thanks for merging them :-) |
@kentcdodds @JaKXz mind giving an update I just published a spin?
We've pulled out source-map support into istanbuljs. |
@bcoe LGTM on |
I am seeing new issues with |
continued from: #286 (comment)
Minimal reproduction: https://gist.github.com/JaKXz/e91baeead7f4ff2df6825abf33327479
Similar [but not necessarily related] error with v6.6.x and the
--all
flag and__coverage__
plugin: https://github.com/JaKXz/react-redux-starter/tree/d0bc516cdea96e45b75d6ad585bc6c9b6f3fb97c@bcoe @gotwarlost et al
The text was updated successfully, but these errors were encountered: