Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nyc@7.0.0-alpha3 lcov report broken #288

Closed
JaKXz opened this issue Jun 28, 2016 · 6 comments
Closed

nyc@7.0.0-alpha3 lcov report broken #288

JaKXz opened this issue Jun 28, 2016 · 6 comments

Comments

@JaKXz
Copy link
Member

JaKXz commented Jun 28, 2016

continued from: #286 (comment)

Minimal reproduction: https://gist.github.com/JaKXz/e91baeead7f4ff2df6825abf33327479

Similar [but not necessarily related] error with v6.6.x and the --all flag and __coverage__ plugin: https://github.com/JaKXz/react-redux-starter/tree/d0bc516cdea96e45b75d6ad585bc6c9b6f3fb97c

@bcoe @gotwarlost et al

@bcoe
Copy link
Member

bcoe commented Jun 28, 2016

@JaKXz @gotwarlost interestingly enough, works well with the new babel-plugin-istanbul:

{
  "name": "nyc-ava-test",
  "version": "1.0.0",
  "description": "",
  "main": "say.js",
  "scripts": {
    "test": "nyc -r lcov ava"
  },
  "author": "",
  "license": "ISC",
  "babel": {
    "presets": [
      "es2015"
    ],
    "plugins": [
      "istanbul"
    ]
  },
  "nyc": {
    "include": [
      "*.js"
    ],
    "require": [
      "babel-register"
    ],
    "sourceMap": false,
    "instrument": false
  },
  "devDependencies": {
    "ava": "^0.15.1",
    "babel": "^6.5.2",
    "babel-cli": "^6.9.0",
    "babel-plugin-istanbul": "^1.0.0",
    "babel-preset-es2015": "^6.9.0",
    "babel-register": "^6.9.0",
    "nyc": "^7.0.0-alpha.3"
  }
}

underlying problem seems to be bad source-map positions, which I know we've bumped into in a few places. Hopefully this will be fixed once the issue @gotwarlost opened on babel itself is addressed, and once we switch source-map functionality over to using Isanbul directly.

If anyone gets bored @novemberborn, @JaKXz, @jamestalmage, would love help wiring up Istanbul's source-maps, such that we can retire nyc's handling of them.

@JaKXz
Copy link
Member Author

JaKXz commented Jun 28, 2016

@kentcdodds this is the same issue you reported :)

@kentcdodds
Copy link
Member

Ok, I thought it might be :-) Thanks for merging them :-)

@bcoe
Copy link
Member

bcoe commented Jul 2, 2016

@kentcdodds @JaKXz mind giving an update I just published a spin?

npm cache clear; npm i nyc@next

We've pulled out source-map support into istanbuljs.

@JaKXz
Copy link
Member Author

JaKXz commented Jul 2, 2016

@bcoe LGTM on alpha4 not using babel-plugin-istanbul.

@JaKXz
Copy link
Member Author

JaKXz commented Jul 2, 2016

I am seeing new issues with babel-plugin-istanbul@1.0.1 but it might be because I have an incorrect setup somewhere... let me try to minimally reproduce and I'll make a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants