Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove greenkeeper ignore for find-up #768

Merged
merged 1 commit into from
Feb 13, 2018
Merged

chore: remove greenkeeper ignore for find-up #768

merged 1 commit into from
Feb 13, 2018

Conversation

realityking
Copy link
Contributor

Originally this was added in #402 but find-up has since been updated

Originally this was added in #402 but find-up has since been updated
@realityking
Copy link
Contributor Author

Also looks like greenkeeper has been disabled - all the more reason to remove it.

@JaKXz
Copy link
Member

JaKXz commented Feb 6, 2018

My opinion is that greenkeeper might become useful again, so this config isn't hurting us. My understanding is that we've disabled greenkeeper temporarily to try to reduce the issue/PR noise while we triage everything and try to get more issues closed/bugs fixed/PRs merged.

@realityking
Copy link
Contributor Author

@JaKXz I agree but since find-up has already been updated ignoring it in the Greenkeeper config is actually harmful if you decide to use Greenkeeper again.

@bcoe bcoe merged commit d19fc4f into istanbuljs:master Feb 13, 2018
@bcoe
Copy link
Member

bcoe commented Feb 13, 2018

@realityking @JaKXz I'm fine with removing this config -- I believe it's an artifact from wanting to be backwards compatible to Node 0.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants