Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "sleep" sample throughout Istio docs #15767

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

craigbox
Copy link
Contributor

@craigbox craigbox commented Oct 8, 2024

Having introduced a sample service named curl in istio/istio#53381, this PR attempts a giant replacement of sleep throughout the Istio docs.

@craigbox craigbox requested review from a team as code owners October 8, 2024 08:08
@istio-testing istio-testing added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 8, 2024
@craigbox craigbox mentioned this pull request Oct 8, 2024
@craigbox
Copy link
Contributor Author

craigbox commented Oct 8, 2024

https://storage.googleapis.com/istio-prow/pr-logs/pull/istio_istio.io/15767/doc.test.dualstack_istio.io/1843579875621867520/artifacts/tests-setup-dualstack-a9b80b2bb/TestDocs/setup/additional-setup/dual-stack/test.sh/test.sh/_test_context/test.sh_output.txt

error: the path "samples/curl/curl.yaml" does not exist

(This PR needs to wait until the automator has caught up, which I think @bleggett is working on.)

@bleggett
Copy link
Contributor

bleggett commented Oct 8, 2024

https://storage.googleapis.com/istio-prow/pr-logs/pull/istio_istio.io/15767/doc.test.dualstack_istio.io/1843579875621867520/artifacts/tests-setup-dualstack-a9b80b2bb/TestDocs/setup/additional-setup/dual-stack/test.sh/test.sh/_test_context/test.sh_output.txt

error: the path "samples/curl/curl.yaml" does not exist

(This PR needs to wait until the automator has caught up, which I think @bleggett is working on.)

Manual rebase of the automator PR from ~3 days ago here: #15768, once that's merged you should be mostly up to date.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 9, 2024
@craigbox craigbox requested a review from a team as a code owner October 9, 2024 23:28
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Oct 9, 2024
@craigbox
Copy link
Contributor Author

@dhawton tests pass - hopefully the commits I have somehow picked during rebase are appropriate!

@craigbox
Copy link
Contributor Author

Sort order bug:

VERIFY FAILED snip_deploy_a_sample_application_3 (timeout after 120s):
received:
"NAME                            READY   STATUS    RESTARTS   AGE
curl-6f9bc47956-5w47h           2/2     Running   0          2m1s
helloworld-v1-bfb69958d-mvwxd   2/2     Running   0          2m1s"
expected:
"NAME                             READY   STATUS    RESTARTS   AGE
helloworld-v1-776f57d5f6-s7zfc   2/2     Running   0          10s
curl-64d7d56698-wqjnm            2/2     Running   0          9s"

@craigbox
Copy link
Contributor Author

#15505 flaaaaaake

/test doc.test.profile-default

@craigbox
Copy link
Contributor Author

/test doc.test.profile-default

@craigbox
Copy link
Contributor Author

#15505 flaaaaaake

/test doc.test.profile-default

1 similar comment
@craigbox
Copy link
Contributor Author

#15505 flaaaaaake

/test doc.test.profile-default

@craigbox
Copy link
Contributor Author

#15505 🤬

/test doc.test.profile-default

@istio-testing istio-testing merged commit 580ea90 into istio:master Oct 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants