From bc48ebd147f741d1ffdb1081ab298fb18f6bfe03 Mon Sep 17 00:00:00 2001 From: Steven Jin Xuan Date: Tue, 15 Aug 2023 22:38:21 +0000 Subject: [PATCH 1/2] Add GET method for admin logging endpoint Signed-off-by: Steven Jin Xuan --- src/admin.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/admin.rs b/src/admin.rs index b5bc7f6f5..c2eae0327 100644 --- a/src/admin.rs +++ b/src/admin.rs @@ -309,7 +309,9 @@ async fn handle_config_dump( //mirror envoy's behavior: https://www.envoyproxy.io/docs/envoy/latest/operations/admin#post--logging //NOTE: multiple query parameters is not supported, for example //curl -X POST http://127.0.0.1:15000/logging?"tap=debug&router=debug" +//Also, at a GET endpoint since browsers send GET requests when visiting a site. static HELP_STRING: &str = " +usage: GET /logging\t\t\t\t\t\t(To list current level) usage: POST /logging\t\t\t\t\t\t(To list current level) usage: POST /logging?level=\t\t\t\t(To change global levels) usage: POST /logging?level={mod1}:{level1},{mod2}:{level2}\t(To change specific mods' logging level) @@ -337,6 +339,7 @@ async fn handle_logging(req: Request) -> Response> { list_loggers() } } + hyper::Method::GET => list_loggers(), _ => plaintext_response( hyper::StatusCode::METHOD_NOT_ALLOWED, format!("Invalid HTTP method\n {HELP_STRING}"), From bb31a98af38637d2f92cbd403822c9b8abadf95e Mon Sep 17 00:00:00 2001 From: Steven Jin Xuan Date: Tue, 15 Aug 2023 22:49:35 +0000 Subject: [PATCH 2/2] typo --- src/admin.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/admin.rs b/src/admin.rs index c2eae0327..3222efb63 100644 --- a/src/admin.rs +++ b/src/admin.rs @@ -309,7 +309,7 @@ async fn handle_config_dump( //mirror envoy's behavior: https://www.envoyproxy.io/docs/envoy/latest/operations/admin#post--logging //NOTE: multiple query parameters is not supported, for example //curl -X POST http://127.0.0.1:15000/logging?"tap=debug&router=debug" -//Also, at a GET endpoint since browsers send GET requests when visiting a site. +//Also, add a GET endpoint since browsers send GET requests when visiting a site. static HELP_STRING: &str = " usage: GET /logging\t\t\t\t\t\t(To list current level) usage: POST /logging\t\t\t\t\t\t(To list current level)