Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Tests D-2.4 / D-2.5 / D-3.5 / D-3.6 fail if printer doesn't support US Letter or A4 #99

Open
wifiprintguy opened this issue Aug 10, 2023 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@wifiprintguy
Copy link
Collaborator

wifiprintguy commented Aug 10, 2023

The Document Tests in the current IPP Everywhere Self-Certification Manual v1.1 (5100.20-2020) define tests D-2.4, D-2.5, D-3.5 and D-3.6 such that the printer has to support US Letter and A4. If the printer does not support these media sizes, then the tests will fail. This seems unreasonable.

To resolve this issue, the tests themselves could be updated so that they are only run if that media size is supported.

For instance, Test D-2.4 is defined thus in sw-ippeveselfcert11-20220819:

{
	SKIP-IF-NOT-DEFINED HAVE_COLOR
	NAME "D-2.4 Print color.jpg with media=na_letter_8.5x11in and ipp-attribute-fidelity=true"
	OPERATION Print-Job
	GROUP operation-attributes-tag
	ATTR charset attributes-charset utf-8
	ATTR naturalLanguage attributes-natural-language en
	ATTR uri printer-uri $uri
	ATTR name requesting-user-name $user
	ATTR name job-name "D-2.4 color.jpg with media=na_letter_8.5x11in and ipp-attribute-fidelity=true"
	ATTR mimeMediaType document-format "image/jpeg"
	ATTR boolean ipp-attribute-fidelity true
	GROUP job-attributes-tag
	ATTR keyword media na_letter_8.5x11in
	FILE "color.jpg"

	STATUS successful-ok
	STATUS server-error-busy REPEAT-MATCH REPEAT-LIMIT 30
}

This test fails because there is no check for US Letter media support. There are already DEFINE-MATCH clauses in test D-1 to define HAVE_A4 and HAVE_LETTER. So all that would be needed would be for this to work for printers that don't support this media size is for a "SKIP-IF-NOT-DEFINED HAVE_LETTER" to be added at the start. Similar fixes for D-2.5, D-3.5 and D-3.6.

@wifiprintguy wifiprintguy added the bug Something isn't working label Aug 10, 2023
@wifiprintguy wifiprintguy added this to the v1.1 Tools milestone Aug 10, 2023
@wifiprintguy
Copy link
Collaborator Author

And just a reminder that the "SKIP-IF-NOT-DEFINED HAVE_LETTER" additions to the Print-Job test will also need to be in the Get-Job-Attributes test following it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant