Fixed the ability to save answer of question when type is Open Answer #3148

amoutens · 2025-01-28T17:09:08Z

Fixed ability to save Open Answer answers
Provided opportunity to add more than one answer for Open Answer
Added styles for edit open answer question
Added error handling on blur when we input empty new value
Provided functional and styles for checking right answer when Open Answer

…-open-answer

src/components/question-editor/QuestionEditor.tsx

src/containers/my-quizzes/create-or-edit-quiz-question/CreateOrEditQuizQuestion.tsx

src/containers/quiz/quiz-question/Question.tsx

ShadowOfTheSpace · 2025-01-30T16:55:10Z

tests/unit/containers/my-quizzes/CreateOrEditQuizQuestion.spec.jsx

+  title: 'Question title',
+  text: 'Question text',
+  answers: [
+    {id: 0, text: 'Answer 1', isCorrect: true },


Format this line, please

tests/unit/containers/my-quizzes/CreateOrEditQuizQuestion.spec.jsx

src/components/question-editor/QuestionEditor.tsx

markgol777 · 2025-02-03T15:15:28Z

src/containers/my-quizzes/create-or-edit-quiz-question/CreateOrEditQuizQuestion.tsx

@@ -150,12 +161,14 @@ const CreateOrEditQuizQuestion: FC<CreateOrEditQuizQuestionProps> = ({
  useEffect(() => {
    !question && onOpenCreateQuestionModal()
    // eslint-disable-next-line react-hooks/exhaustive-deps


Let's try to not use eslint disablers in our project

it isn't mine

Yes, but If you're working on the pr you should fix all of the issues coming with it. In my opinion at least...

I'll try to do my best

Just add useCallback to the onOpenCreateQuestionModal function declaration. This will stabilize the reference for that function, and useEffect will run only if question or onOpenCreateQuestionModal are changed.

markgol777 · 2025-02-03T15:16:49Z

src/types/questions/interfaces/questions.interface.ts

@@ -37,6 +37,7 @@ export interface UpdateQuestionParams {

 export interface QuestionFormAnswer extends Answer {
  id: number
+  isEditing?: boolean


Why isEditing optional?

because isEditing only exists on openAnswer question type

okay then perhaps should we make 2 different types? up 2 u tho

thanks, I'll take a look

I decided to leave as it was because creating 2 different types brings a lot of types mismatches

markgol777 · 2025-02-03T15:18:46Z

Regarding this. This is so called varenychky or gastronomy just rerun the tests and they should work.

Perhaps your coverage will go up too

amoutens · 2025-02-03T15:20:04Z

Regarding this. This is so called varenychky or gastronomy just rerun the tests and they should work.

Perhaps your coverage will go up too

Thanks, I'll try. I'm going to fix some comments and then push again

markgol777 · 2025-02-03T15:24:06Z

Regarding this. This is so called varenychky or gastronomy just rerun the tests and they should work.
Perhaps your coverage will go up too

Thanks, I'll try. I'm going to fix some comments and then push again

It's just enough to push this button but alright

sonarqubecloud · 2025-02-03T17:33:53Z

Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

ShadowOfTheSpace · 2025-02-04T15:06:46Z

src/components/question-editor/QuestionEditor.tsx

-      ]
-      handleNonInputValueChange('answers', addAnswer)
-    }
+    if (isEmptyAnswer) return


Add braces here, please

ShadowOfTheSpace · 2025-02-04T15:12:39Z

src/containers/my-quizzes/create-or-edit-quiz-question/CreateOrEditQuizQuestion.tsx

+  const onOpenCreateQuestionModalRef = useRef(onOpenCreateQuestionModal)

  useEffect(() => {
-    !question && onOpenCreateQuestionModal()
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [])
+    !question && onOpenCreateQuestionModalRef.current()
+  }, [question])


Very strange usage of useRef
Check, please, how it workds without useRef, but with onOpenCreateQuestionModal inside dependency array

ShadowOfTheSpace · 2025-02-04T15:18:21Z

tests/unit/components/question-editor/QuestionEditor.spec.jsx

Format this file, please

ShadowOfTheSpace · 2025-02-04T15:18:39Z

tests/unit/components/question-editor/QuestionEditor.spec.jsx

+    fireEvent.click(addNewOneButton)
+
+    expect(handleNonInputValueChange).toHaveBeenCalledWith("answers", [
+      { id: 0, text: "", isCorrect: true, isEditing: true },


Suggested change

{ id: 0, text: "", isCorrect: true, isEditing: true },

{ id: 0, text: '', isCorrect: true, isEditing: true },

ShadowOfTheSpace · 2025-02-04T15:19:39Z

tests/unit/containers/my-quizzes/CreateOrEditQuizQuestion.spec.jsx

Don't forget to format this file with prettier

ShadowOfTheSpace · 2025-02-04T15:20:00Z

tests/unit/containers/my-quizzes/CreateOrEditQuizQuestion.spec.jsx

@@ -116,6 +129,37 @@ describe('CreateOrEditQuizQuestion component without question', () => {
    expect(snackbar).toBeInTheDocument()
    expect(createQuestionSpy).toHaveBeenCalled()
  })
+  it('should call onCreateQuestion with openAnswer data', async () => {
+    mockAxiosClient
+      .onPost(`${URLs.resources.questions.post}`)


Suggested change

.onPost(`${URLs.resources.questions.post}`)

.onPost(URLs.resources.questions.post)

ShadowOfTheSpace · 2025-02-04T15:21:19Z

tests/unit/containers/quiz/QuizQuestion.spec.jsx

@@ -38,4 +38,24 @@ describe('Quiz Question tests', () => {
    const element = screen.getByText('0/1')
    expect(element).toBeInTheDocument()
  })
+  it('Should render correctness icon if shouldShowAnswersCorrectness is true', () => {


Suggested change

it('Should render correctness icon if shouldShowAnswersCorrectness is true', () => {

it('should render correctness icon if shouldShowAnswersCorrectness is true', () => {

ShadowOfTheSpace · 2025-02-04T15:21:26Z

tests/unit/containers/quiz/QuizQuestion.spec.jsx

+    const icon = screen.getAllByTestId('CheckIcon')[0]
+    expect(icon).toBeInTheDocument()
+  })
+  it('Should render open answer input field', () => {


Suggested change

it('Should render open answer input field', () => {

it('should render open answer input field', () => {

amoutens added 2 commits January 28, 2025 19:06

added saving open answer opportunity

f968d55

added tests

12b3b1a

amoutens marked this pull request as draft January 28, 2025 18:10

amoutens added 2 commits January 30, 2025 12:19

Merge branch 'develop' into bugfix/3146/fix-ability-to-save-answer-if…

6213e01

…-open-answer

fixed output of correctness of open answers

2be9d12

amoutens self-assigned this Jan 30, 2025

amoutens added 3 commits January 30, 2025 14:06

added global react import

13ca7e8

optimized parts of code

8b96ff0

added more tests

cec960d

amoutens linked an issue Jan 30, 2025 that may be closed by this pull request

(SP: ) Fix the ability to save answer of question when type is Open Answer #3146

Open

amoutens added bug Something isn't working Frontend part Functional Something isn't working labels Jan 30, 2025

amoutens marked this pull request as ready for review January 30, 2025 13:23

amoutens requested review from markgol777, Made1ra, Mike-Popovych, SofiiaYevush, ShadowOfTheSpace, luiqor and nebby2105 January 30, 2025 13:24

amoutens added 2 commits January 30, 2025 18:30

replaced functions by callbacks

f486d55

returned old expressions

6c90fa4

ShadowOfTheSpace requested changes Jan 30, 2025

View reviewed changes

fixed comments

946f673

markgol777 requested changes Feb 3, 2025

View reviewed changes

fixed comments

eb8c585

amoutens requested review from markgol777 and ShadowOfTheSpace February 3, 2025 17:34

ShadowOfTheSpace requested changes Feb 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed the ability to save answer of question when type is Open Answer #3148

Fixed the ability to save answer of question when type is Open Answer #3148

amoutens commented Jan 28, 2025 •

edited

Loading

ShadowOfTheSpace Jan 30, 2025

markgol777 Feb 3, 2025

amoutens Feb 3, 2025

markgol777 Feb 3, 2025

amoutens Feb 3, 2025

ShadowOfTheSpace Feb 3, 2025

markgol777 Feb 3, 2025

amoutens Feb 3, 2025

markgol777 Feb 3, 2025

amoutens Feb 3, 2025

amoutens Feb 3, 2025

markgol777 commented Feb 3, 2025 •

edited

Loading

amoutens commented Feb 3, 2025

markgol777 commented Feb 3, 2025

sonarqubecloud bot commented Feb 3, 2025

ShadowOfTheSpace Feb 4, 2025

ShadowOfTheSpace Feb 4, 2025

ShadowOfTheSpace Feb 4, 2025

ShadowOfTheSpace Feb 4, 2025

ShadowOfTheSpace Feb 4, 2025

ShadowOfTheSpace Feb 4, 2025

ShadowOfTheSpace Feb 4, 2025

ShadowOfTheSpace Feb 4, 2025

	{ id: 0, text: "", isCorrect: true, isEditing: true },
	{ id: 0, text: '', isCorrect: true, isEditing: true },

	.onPost(`${URLs.resources.questions.post}`)
	.onPost(URLs.resources.questions.post)

	it('Should render correctness icon if shouldShowAnswersCorrectness is true', () => {
	it('should render correctness icon if shouldShowAnswersCorrectness is true', () => {

	it('Should render open answer input field', () => {
	it('should render open answer input field', () => {

Fixed the ability to save answer of question when type is Open Answer #3148

Are you sure you want to change the base?

Fixed the ability to save answer of question when type is Open Answer #3148

Conversation

amoutens commented Jan 28, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markgol777 commented Feb 3, 2025 • edited Loading

amoutens commented Feb 3, 2025

markgol777 commented Feb 3, 2025

sonarqubecloud bot commented Feb 3, 2025

Quality Gate failed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amoutens commented Jan 28, 2025 •

edited

Loading

markgol777 commented Feb 3, 2025 •

edited

Loading