Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create component for platform details page buttons row #1462

Open
smonolo opened this issue Mar 30, 2024 · 2 comments · May be fixed by #1510
Open

Create component for platform details page buttons row #1462

smonolo opened this issue Mar 30, 2024 · 2 comments · May be fixed by #1510

Comments

@smonolo
Copy link
Contributor

smonolo commented Mar 30, 2024

Is your feature request related to a problem? Please describe.

Each platform has its own details page, and almost all of them have a set of buttons that bring to the same or similar links. At the moment, each page has a copy of the buttons row that stands on its own, repeated dozens of times.

Describe the solution you'd like

Goal is to create an include that accepts a few props, that renders the row. This way the repeated code would be removed and everything could be managed in the new component, making it quicker and easier to add new things as needed.

Describe alternatives you've considered

N/A

Additional context

18app details page:

image

@Gagan20-vis
Copy link

Hi @smonolo , according to the problem described, we need a component for a row of buttons that takes a few props and that we can reuse in different components. Is it correct?

@smonolo
Copy link
Contributor Author

smonolo commented May 3, 2024

Hi @Gagan20-vis, thanks for you interest!

You are correct. As you can guess from what's described above, most software pages share a similar row of buttons. They are being placed in each file as a copy paste, and it would be nice to have a shared component that displays these buttons and takes a few props that will be passed by the software file itself, such as slackChannelLink for the software-specific Slack channel link, and so on.

It should be doable easily, but not sure how it would work with MD files. Feel free to ping me again if you have any questions.

Thanks!

@anacardix anacardix linked a pull request Oct 7, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants