Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TXT serializer for validation report #25

Open
psmiraglia opened this issue Apr 23, 2021 · 3 comments
Open

TXT serializer for validation report #25

psmiraglia opened this issue Apr 23, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Hacktoberfest Label

Comments

@psmiraglia
Copy link
Member

psmiraglia commented Apr 23, 2021

Is your feature request related to a problem? Please describe.

With #23, the tool becomes able to save the validation report as JSON. The TXT serialization is just a draft and needs to be implemented.

def _txt_serializer(self, report: Report) -> str:
lines = []
lines.append(f'Result: {report.result}')
lines.append(f'Target: {report.target}')
lines.append(f'Timestamp: {report.timestamp}')
for _lines in [t.as_txt().split('\n') for t in report.tests]:
for line in [f' {_line}' for _line in _lines]:
lines.append(line)
return '\n'.join(lines)

Describe the solution you'd like

None

Describe alternatives you've considered

None

Additional context

None

@psmiraglia psmiraglia added the enhancement New feature or request label Apr 23, 2021
@psmiraglia psmiraglia changed the title TXT serialization for report validation TXT serializer for report validation Apr 23, 2021
@psmiraglia psmiraglia changed the title TXT serializer for report validation TXT serializer for validation report Apr 23, 2021
@psmiraglia psmiraglia added the good first issue Good for newcomers label Apr 26, 2021
@astagi astagi added the Hacktoberfest Hacktoberfest Label label Oct 4, 2021
@iflare3g
Copy link

iflare3g commented Oct 6, 2021

hey @astagi 😃 nice to meet u again ( first time at Python Pizza a couple of years ago 🍕 ) I can take a look at it, but it could help having the expected txt or a mocked example of it that this serializer should generate
just to go faster

thanks!

@astagi
Copy link
Member

astagi commented Oct 6, 2021

Hey @iflare3g nice to meet you again, yes I remember :) maybe @psmiraglia or @peppelinux could help you!

@iflare3g
Copy link

iflare3g commented Oct 6, 2021

Great, thanks so much for answering!
So @psmiraglia @peppelinux lemme know and I'll be happy to help 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Hacktoberfest Hacktoberfest Label
Projects
None yet
Development

No branches or pull requests

3 participants