Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The check on IPACode is wrong #50

Open
fume opened this issue Oct 13, 2022 · 1 comment
Open

The check on IPACode is wrong #50

fume opened this issue Oct 13, 2022 · 1 comment

Comments

@fume
Copy link
Contributor

fume commented Oct 13, 2022

If there are more than one AOO for the same IPAcode, the check fails.
i.e. searching for the IPA uni_bo, the response has
"numeroRigheTotali": 53,
but the code checks exactly for "numeroRigheTotali": 1
The check should verify if numeroRigheTotali is greater than 0, not equal to 1.

Moreover, the CHECK_URL variable doesn't exist, so the error message is partial (as pointed out also on issue #47).

if curl -X POST https://indicepa.gov.it/PortaleServices/api/aoo -H "Content-Type: application/json" -d ${JSON} | grep -qv '"numeroRigheTotali":1'; then
die "[E] ORGANIZATION_IDENTIFIER refers to something that does not exists \n [I] Check it by yourself at ${CHECK_URL}"
fi

@damikael
Copy link
Member

See: #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants