Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chacksignature fatto con la key presente nella risposta #45

Open
pomarc opened this issue Oct 17, 2022 · 0 comments
Open

Chacksignature fatto con la key presente nella risposta #45

pomarc opened this issue Oct 17, 2022 · 0 comments

Comments

@pomarc
Copy link

pomarc commented Oct 17, 2022 •
edited
Loading

nella verifica della signature della response

spid-dotnet-sdk/Italia.Spid.Authentication/Saml/XmlSigningHelper.cs

Line 110 in 9cb6135

return signedXml.CheckSignature();

viene usato l'overload della chiamata che non passa la chiave pubblica del firmatario, ma usa quella nel nodo KeyInfo.

E' abbastanza sicuro? non sarebbe più corretto utilizzare la chiave pubblica estratta dal metadata dell'IdP?

cfr (https://learn.microsoft.com/en-us/dotnet/api/system.security.cryptography.xml.signedxml?view=dotnet-plat-ext-6.0#security-considerations-about-the-keyinfo-element)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pomarc