FIX-modin-project#2172: support float32 in calcite serializer (modin-…

…project#2173) Signed-off-by: ienkovich <ilya.enkovich@intel.com>
itamarst · Sep 29, 2020 · 623de5c · 623de5c
1 parent 4a0c719
commit 623de5c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/modin/experimental/engines/omnisci_on_ray/frame/calcite_serializer.py b/modin/experimental/engines/omnisci_on_ray/frame/calcite_serializer.py
@@ -41,6 +41,7 @@ class CalciteSerializer:
         "int32": "INTEGER",
         "int64": "BIGINT",
         "bool": "BOOLEAN",
+        "float32": "FLOAT",
         "float64": "DOUBLE",
     }
 

diff --git a/modin/experimental/engines/omnisci_on_ray/test/test_dataframe.py b/modin/experimental/engines/omnisci_on_ray/test/test_dataframe.py
@@ -275,6 +275,20 @@ def test_sep_delimiter(self, kwargs):
 
         df_equals(modin_df, pandas_df)
 
+    @pytest.mark.skip(reason="https://github.com/modin-project/modin/issues/2174")
+    def test_float32(self):
+        csv_file = os.path.join(self.root, "modin/pandas/test/data", "test_usecols.csv")
+        kwargs = {
+            "dtype": {"a": "float32", "b": "float32"},
+        }
+
+        pandas_df = pandas.read_csv(csv_file, **kwargs)
+        pandas_df["a"] = pandas_df["a"] + pandas_df["b"]
+        modin_df = pd.read_csv(csv_file, **kwargs, engine="arrow")
+        modin_df["a"] = modin_df["a"] + modin_df["b"]
+
+        df_equals(modin_df, pandas_df)
+
 
 class TestMasks:
     data = {