Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replays upside down #118

Closed
mad-s opened this issue Aug 10, 2015 · 2 comments
Closed

Replays upside down #118

mad-s opened this issue Aug 10, 2015 · 2 comments
Labels

Comments

@mad-s
Copy link
Contributor

mad-s commented Aug 10, 2015

When viewing replays and the "Hard Rock" mod state is not equal to it's state at the time the replay was created, the replay is upside down.

@mad-s
Copy link
Contributor Author

mad-s commented Aug 10, 2015

There seem to be a lot of issues involving mods and replays due to getting the current value and not the stored value. (See #116)

@itdelatrisu
Copy link
Owner

I'll look into this. Part of the problem is that this isn't getting called early enough in Game.enter(...):

            if (isReplay) {
                previousMods = GameMod.getModState();
                GameMod.loadModState(replay.mods);
            }

If I move that up near the top of the method, it fixes the issue with Hard Rock. Checking out if your fix in #117 is still necessary...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants