Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

progress bar not showing by default #2645

Closed
efiop opened this issue Oct 21, 2019 · 2 comments
Closed

progress bar not showing by default #2645

efiop opened this issue Oct 21, 2019 · 2 comments
Assignees
@casperdcl
Labels
bug Did we break something? p0-critical Critical issue. Needs to be fixed ASAP.

Comments

@efiop
Copy link
Contributor

efiop commented Oct 21, 2019

#2550

@casperdcl Commenting out disable code makes it work.
@efiop efiop added bug Did we break something? p0-critical Critical issue. Needs to be fixed ASAP. labels Oct 21, 2019
@efiop
Copy link
Contributor Author

efiop commented Oct 21, 2019

@casperdcl https://github.com/iterative/dvc/blob/master/dvc/progress.py#L92 should probably be

disable = not file.isatty()

?

@efiop efiop closed this as completed in 2274261 Oct 21, 2019
@casperdcl
Copy link
Contributor

yes. definitely. ahem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@casperdcl casperdcl

Labels
bug Did we break something? p0-critical Critical issue. Needs to be fixed ASAP.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@efiop @casperdcl