Result inconsistency for __call__
, is_ignored_file
and is_ignored_dir
#4333
Labels
bug
Did we break something?
help wanted
p2-medium
Medium priority, should be done, but less important
Bug Report
Please provide information about your setup
Output of
dvc version
:$ dvc version
master
Additional Information (if any):
If applicable, please also provide a
--verbose
output of the command, eg:dvc add --verbose
.Now there are several interfaces for the dvcignore.
In
is_ignored_dir
we ignored all paths outside the repo.dvc/dvc/ignore.py
Lines 270 to 272 in 35dd1fd
In a direct call
__call__
all outside paths are included.dvc/dvc/ignore.py
Lines 241 to 244 in 35dd1fd
And in
is_ignored_files
there is a bug that makes us skipped "outside the repo" check and return False forever.dvc/dvc/ignore.py
Lines 275 to 278 in 35dd1fd
They should be unified. So in what condition do we need to mask files outside the repo? And should we put this logic in dvcignore?
The text was updated successfully, but these errors were encountered: