Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke testing #4347

Closed
skshetry opened this issue Aug 6, 2020 · 4 comments
Closed

Smoke testing #4347

skshetry opened this issue Aug 6, 2020 · 4 comments
Labels
p2-medium Medium priority, should be done, but less important testing Related to the tests and the testing infrastructure

Comments

@skshetry
Copy link
Member

skshetry commented Aug 6, 2020

It'd be great if we could do a smoke testing before releases.

See: #4318

@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Aug 6, 2020
@efiop efiop added the testing Related to the tests and the testing infrastructure label Aug 6, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Aug 6, 2020
@efiop
Copy link
Contributor

efiop commented Aug 6, 2020

@skshetry Could you elaborate on how you see it applied in dvc?

@efiop efiop added the p3-nice-to-have It should be done this or next sprint label Aug 6, 2020
@skshetry
Copy link
Member Author

skshetry commented Aug 6, 2020

  1. Build package.
  2. Run tests (e2e types) that are critical for the release.
  3. Deploy package if it passes.

We could create a separate repository for this and run those scripts before "deploying".

@skshetry
Copy link
Member Author

skshetry commented Aug 6, 2020

And, on smoke tests, we should test something that's very simple (dvc add directory/file, import/get, etc) and/or something that differs between different packages (eg: related to dependencies, etc). Any other kinds of tests can be added as we see fit later on.

And, other specialized tests can be easily covered with our func/unit tests (even if it is not, smoketest won't help here).

@efiop efiop added p2-medium Medium priority, should be done, but less important and removed p3-nice-to-have It should be done this or next sprint labels Oct 8, 2021
@skshetry
Copy link
Member Author

Closing as stale.

@skshetry skshetry closed this as not planned Won't fix, can't repro, duplicate, stale May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-medium Medium priority, should be done, but less important testing Related to the tests and the testing infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants