Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-url, import-url: handle empty directory imports #5521

Open
isidentical opened this issue Feb 25, 2021 · 3 comments
Open

get-url, import-url: handle empty directory imports #5521

isidentical opened this issue Feb 25, 2021 · 3 comments
Assignees
Labels
bug Did we break something? upstream Issues which need to be resolved in an upstream dependency

Comments

@isidentical
Copy link
Contributor

When getting/importing an empty directory, we don't take any actions in the workspace since we don't create the parent directories unless there are files.

dvc import-url some://empty/dir/
dvc get-url some://empty/dir/
@isidentical isidentical self-assigned this Feb 25, 2021
@isidentical isidentical added the bug Did we break something? label Feb 25, 2021
@isidentical
Copy link
Contributor Author

Awaiting fixes on the upstream implementations (adlfs, gcsfs) before we can act.

@isidentical isidentical added the upstream Issues which need to be resolved in an upstream dependency label Mar 16, 2021
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Mar 17, 2021

When getting/importing an empty directory, we don't take any actions in the workspace

Actually it currently fails with some repetitive and contradicting messaging 🙂

$  dvc import-url ../ext/empty
Importing '../ext/empty' -> 'empty'
WARNING: '../ext/empty' is empty.
WARNING: '../ext/empty' is empty.
ERROR: failed to import ../ext/empty. You could also try downloading it manually,
and adding it with `dvc add`. - output 'empty' does not exist

Contradiction: "is empty" vs. "does not exist"

DVC 2.0.5 (pip)

@isidentical
Copy link
Contributor Author

Awaiting: fsspec/filesystem_spec#562 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something? upstream Issues which need to be resolved in an upstream dependency
Projects
None yet
Development

No branches or pull requests

2 participants