Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert temporary azure changes and update adlfs to 0.7.5 #6023

Closed
friggog opened this issue May 17, 2021 · 2 comments · Fixed by #6323
Closed

Revert temporary azure changes and update adlfs to 0.7.5 #6023

friggog opened this issue May 17, 2021 · 2 comments · Fixed by #6323
Assignees
@isidentical
Labels
fs: azure Related to the Azure filesystem maintenance

Comments

@friggog
Copy link
Contributor

friggog commented May 17, 2021 •
edited
Loading

As of fsspec/adlfs#229 the issue with event loops in adlfs is resolved, the temporary solution from @isidentical for DVC in #5958 can be reverted with adlfs requirement pinned to 0.7.5 instead of 0.7.1

I've tested this with DVC 2.1.0 and manually installed adlfs 0.7.5 and everything seems to work

PS it would be great to have this (or the previous hack) in a DVC release soon so I can update my packages to make use of it! 😄
@efiop efiop added fs: azure Related to the Azure filesystem maintenance labels May 17, 2021
@isidentical
Copy link
Contributor

Pre-requisite: fsspec/filesystem_spec#658

@isidentical
Copy link
Contributor

Pre-requisite: fsspec/filesystem_spec/pull/671

@isidentical isidentical mentioned this issue Jul 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isidentical isidentical

Labels
fs: azure Related to the Azure filesystem maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

azure: move to default fsspec loop isidentical/dvc
3 participants
@efiop @friggog @isidentical