isatty #2550
Merged
isatty #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suor
suggested changes
Sep 30, 2019
Suor
suggested changes
Sep 30, 2019
Suor
suggested changes
Oct 1, 2019
Suor
suggested changes
Oct 1, 2019
efiop
reviewed
Oct 14, 2019
efiop
reviewed
Oct 16, 2019
|
@Suor Please take a look. |
Suor
suggested changes
Oct 17, 2019
tests/unit/test_progress.py
Outdated
Comment on lines
22
to
26
| if DVC_ISATTY: | ||
| assert "0/10" in out_err.err | ||
| else: | ||
| assert out_err.err == "" |
There was a problem hiding this comment.
This if doesn't make much sense if we only test one of its branches.
There was a problem hiding this comment.
may test both depending on env vars when the test is run
There was a problem hiding this comment.
But in conftest.py it's set to True for all tests.
There was a problem hiding this comment.
hmm yes but I feel this way is more future proof. I don't know what your test framework conventions are so can't really decide. At a minimum I think at least a comment would be required around these lines.
- update tests - add documentation
- partially reverts commit 524a0df188f566fb3e103f6965f1b6ac9c530886 - fixes https://github.com/iterative/dvc/pull/2550/files/ad1f245107c405697c4b61fe58a92fc0265c6588#r335811639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2549 non-tty output
Tqdmwhenisatty()isatty()