{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":90276704,"defaultBranch":"master","name":"cockroach","ownerLogin":"itsbilal","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2017-05-04T15:03:58.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/345332?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1726629290.0","currentOid":""},"activityList":{"items":[{"before":"a4131c262223cbd5ecdf00815a412d831f1d0f5f","after":"7cd25994fad8910f5f6e5e9060e2de29d502f938","ref":"refs/heads/add-drtrun-yaml","pushedAt":"2024-09-18T20:08:34.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"cmd/drt-run: check in drt-chaos.yaml file\n\nThis file checks in a drt-chaos.yaml file for use\nwith drt-run to run operations and workloads on the drt-chaos\ncluster.\n\nEpic: none\n\nRelease note: None","shortMessageHtmlLink":"cmd/drt-run: check in drt-chaos.yaml file"}},{"before":null,"after":"a4131c262223cbd5ecdf00815a412d831f1d0f5f","ref":"refs/heads/add-drtrun-yaml","pushedAt":"2024-09-18T03:14:50.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"cmd/drt-run: check in drt-chaos.yaml file\n\nThis file checks in a drt-chaos.yaml file for use\nwith drt-run to run operations and workloads on the drt-chaos\ncluster.\n\nEpic: none\n\nRelease note: None","shortMessageHtmlLink":"cmd/drt-run: check in drt-chaos.yaml file"}},{"before":"539b69864d2f3709d23ef42ded3c0fdb624ca7b1","after":"ef16a9d6057f56466b9f7e5066aed75820f53a7f","ref":"refs/heads/drt-run-2","pushedAt":"2024-09-16T17:05:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"cmd: add drt-run commmand\n\nThis command adds drt-run, a relatively simple go-based binary\nthat concurrently executes some workloads as defined in a config\nYAML file, as well as multiple operation workers that schedule and\nrun operations concurrently. The actual running of workloads\nand operations is done by subprocesses of `workload` and\n`roachtest` managed by this command, mostly to reduce code\ninter-dependencies between the roachtest package and this package.\n\nThis command also supports an http endpoint that shows recent log\nentries from each operation and workload.\n\nEpic: none\n\nRelease note: None","shortMessageHtmlLink":"cmd: add drt-run commmand"}},{"before":null,"after":"6df62b372f1182cfa421a380c7bdf08c9c5b3ab6","ref":"refs/heads/drt-enable-wal-failover","pushedAt":"2024-09-04T19:33:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"drtprod: enable wal failover on drt-chaos and drt-large\n\nPreviously, WAL failover was not turned on on drt-large and\ndrt-chaos despite those clusters having multiple stores.\nThis change updates the drtprod script to pass in\nthe among-stores flag for wal failover to turn it on.\n\nEpic: none\n\nRelease note: None","shortMessageHtmlLink":"drtprod: enable wal failover on drt-chaos and drt-large"}},{"before":"fa7c1ef230fcb853bf03c5a1681c135b3c62b9e0","after":"d2bde904b7678644de9ad35f62348e207933dab3","ref":"refs/heads/backport24.1-129882","pushedAt":"2024-09-04T15:24:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"roachtest: delay verification of disagg-rebalance condition\n\nPreviously, the disagg-rebalance roachtest can flake if the\nlivebytes metric has not been updated with stats post snapshot\napplication. This change throws this verification step behind\na testutils.SucceedsWithin so we wait for an update for the\nnumber of bytes in a range, to be able to accurately determine\nif we did a fast rebalance or not.\n\nEpic: none\nFixes: #128528\n\nRelease note: None","shortMessageHtmlLink":"roachtest: delay verification of disagg-rebalance condition"}},{"before":"1506f6db89579eb7b67639c871a563ec0e75e4d4","after":"fa7c1ef230fcb853bf03c5a1681c135b3c62b9e0","ref":"refs/heads/backport24.1-129882","pushedAt":"2024-09-04T15:23:44.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"roachtest: delay verification of disagg-rebalance condition\n\nPreviously, the disagg-rebalance roachtest can flake if the\nlivebytes metric has not been updated with stats post snapshot\napplication. This change throws this verification step behind\na testutils.SucceedsWithin so we wait for an update for the\nnumber of bytes in a range, to be able to accurately determine\nif we did a fast rebalance or not.\n\nEpic: none\nFixes: #128528\n\nRelease note: None","shortMessageHtmlLink":"roachtest: delay verification of disagg-rebalance condition"}},{"before":null,"after":"1506f6db89579eb7b67639c871a563ec0e75e4d4","ref":"refs/heads/backport24.1-129882","pushedAt":"2024-09-04T14:39:41.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"roachtest: delay verification of disagg-rebalance condition\n\nPreviously, the disagg-rebalance roachtest can flake if the\nlivebytes metric has not been updated with stats post snapshot\napplication. This change throws this verification step behind\na testutils.SucceedsWithin so we wait for an update for the\nnumber of bytes in a range, to be able to accurately determine\nif we did a fast rebalance or not.\n\nEpic: none\nFixes: #128528\n\nRelease note: None","shortMessageHtmlLink":"roachtest: delay verification of disagg-rebalance condition"}},{"before":"d6d80ba7b867be90eba276c10bc76741dbdb7f43","after":null,"ref":"refs/heads/backport24.1-129882","pushedAt":"2024-09-04T14:38:13.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"}},{"before":null,"after":"d6d80ba7b867be90eba276c10bc76741dbdb7f43","ref":"refs/heads/backport24.1-129882","pushedAt":"2024-09-04T14:37:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"roachtest: delay verification of disagg-rebalance condition\n\nPreviously, the disagg-rebalance roachtest can flake if the\nlivebytes metric has not been updated with stats post snapshot\napplication. This change throws this verification step behind\na testutils.SucceedsWithin so we wait for an update for the\nnumber of bytes in a range, to be able to accurately determine\nif we did a fast rebalance or not.\n\nEpic: none\nFixes: #128528\n\nRelease note: None","shortMessageHtmlLink":"roachtest: delay verification of disagg-rebalance condition"}},{"before":null,"after":"8805cb9bad38efe6ed51600a603f6f5a9de135e8","ref":"refs/heads/disagg-rebalance-wait-for-stats","pushedAt":"2024-08-29T17:27:58.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"roachtest: delay verification of disagg-rebalance condition\n\nPreviously, the disagg-rebalance roachtest can flake if the\nlivebytes metric has not been updated with stats post snapshot\napplication. This change throws this verification step behind\na testutils.SucceedsWithin so we wait for an update for the\nnumber of bytes in a range, to be able to accurately determine\nif we did a fast rebalance or not.\n\nEpic: none\nFixes: #128528\n\nRelease note: None","shortMessageHtmlLink":"roachtest: delay verification of disagg-rebalance condition"}},{"before":"a0f0dd3f40c0ddd69c273967053d784903c2ad55","after":"ef16081823d158902ac907cae52ee7d70b275c8d","ref":"refs/heads/reenable-snapshot-splits","pushedAt":"2024-08-16T15:19:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: reenable splitting of snapshot sstables\n\nThis change updates the snapshot strategy's sender side\nto iterate over points and ranges together, instead of only\niterating on points first, then only ranges. This allows us to\nmore efficiently split snapshot sstables on the receiver side.\nTo avoid the need to add a version gate on the receiver side, we\npropagate a bool, RangeKeysInOrder, to the receiver which is a signal\nto it to enable sstable splits.\n\nFixes #129026.\n\nEpic: none\n\nRelease note: None","shortMessageHtmlLink":"kvserver: reenable splitting of snapshot sstables"}},{"before":"6c1e4e28c191e5799bdf9ab99e227fb561b66f93","after":"a0f0dd3f40c0ddd69c273967053d784903c2ad55","ref":"refs/heads/reenable-snapshot-splits","pushedAt":"2024-08-16T14:51:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: reenable splitting of snapshot sstables\n\nThis change updates the snapshot strategy's sender side\nto iterate over points and ranges together, instead of only\niterating on points first, then only ranges. This allows us to\nmore efficiently split snapshot sstables on the receiver side.\nTo avoid the need to add a version gate on the receiver side, we\npropagate a bool, RangeKeysInOrder, to the receiver which is a signal\nto it to enable sstable splits.\n\nFixes #129026.\n\nEpic: none\n\nRelease note: None","shortMessageHtmlLink":"kvserver: reenable splitting of snapshot sstables"}},{"before":"918f10b8d2cb1031933b31596f348973d328acb0","after":"6c1e4e28c191e5799bdf9ab99e227fb561b66f93","ref":"refs/heads/reenable-snapshot-splits","pushedAt":"2024-08-15T20:52:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: reenable splitting of snapshot sstables\n\nThis change updates the snapshot strategy's sender side\nto iterate over points and ranges together, instead of only\niterating on points first, then only ranges. This allows us to\nmore efficiently split snapshot sstables on the receiver side.\nTo avoid the need to add a version gate on the receiver side, we\npropagate a bool, RangeKeysInOrder, to the receiver which is a signal\nto it to enable sstable splits.\n\nFixes #129026.\n\nEpic: none\n\nRelease note: None","shortMessageHtmlLink":"kvserver: reenable splitting of snapshot sstables"}},{"before":null,"after":"918f10b8d2cb1031933b31596f348973d328acb0","ref":"refs/heads/reenable-snapshot-splits","pushedAt":"2024-08-15T20:24:34.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: reenable splitting of snapshot sstables\n\nThis change updates the snapshot strategy's sender side\nto iterate over points and ranges together, instead of only\niterating on points first, then only ranges. This allows us to\nmore efficiently split snapshot sstables on the receiver side.\nTo avoid the need to add a version gate on the receiver side, we\npropagate a bool, RangeKeysInOrder, to the receiver which is a signal\nto it to enable sstable splits.\n\nFixes #129026.\n\nEpic: none\n\nRelease note: None","shortMessageHtmlLink":"kvserver: reenable splitting of snapshot sstables"}},{"before":"2e90d473adce2fe6da800a438a70d2b93ed4ac31","after":"0801a13c6538938838913288600513da27520f12","ref":"refs/heads/disable-sst-split","pushedAt":"2024-08-15T17:15:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: disable snapshot splitting of sstables for now\n\nInforms #129026.\n\nEpic: none\n\nRelease note: None","shortMessageHtmlLink":"kvserver: disable snapshot splitting of sstables for now"}},{"before":null,"after":"2e90d473adce2fe6da800a438a70d2b93ed4ac31","ref":"refs/heads/disable-sst-split","pushedAt":"2024-08-15T16:35:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: disable snapshot splitting of sstables for now\n\nInforms #129026.\n\nEpic: none\n\nRelease note: None","shortMessageHtmlLink":"kvserver: disable snapshot splitting of sstables for now"}},{"before":"4ad1b32be7aefe219547833abf3a0954a23ea4bd","after":"1c4ce426c868cae4c60a365675adfcbfea190f55","ref":"refs/heads/backport24.1-127997","pushedAt":"2024-08-14T21:51:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs\n\nPreviously, we'd only create one sstable for all mvcc keys\nin a range when ingesting a rebalance/recovery snapshot into\nPebble. This increased write-amp in Pebble as more sstables\nwould have to be compacted into it (or the sstable then split\ninto smaller ones in Pebble), and had other consequences\nsuch as massive filter blocks in the large singular sstable.\n\nThis change adds a new cluster setting,\nkv.snapshot_rebalance.max_sst_size, that sets the max size of the\nsstables containing user/mvcc keys in a range. If an sstable exceeds\nthis size in multiSSTWriter, we roll over that sstable and create a\nnew one.\n\nEpic: CRDB-8471\nFixes: #67284\n\nRelease note (performance improvement): Reduce the write-amplification\nimpact of rebalances by splitting snapshot sstable files into smaller ones\nbefore ingesting them into Pebble.","shortMessageHtmlLink":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs"}},{"before":null,"after":"4ad1b32be7aefe219547833abf3a0954a23ea4bd","ref":"refs/heads/backport24.1-127997","pushedAt":"2024-08-14T21:50:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs\n\nPreviously, we'd only create one sstable for all mvcc keys\nin a range when ingesting a rebalance/recovery snapshot into\nPebble. This increased write-amp in Pebble as more sstables\nwould have to be compacted into it (or the sstable then split\ninto smaller ones in Pebble), and had other consequences\nsuch as massive filter blocks in the large singular sstable.\n\nThis change adds a new cluster setting,\nkv.snapshot_rebalance.max_sst_size, that sets the max size of the\nsstables containing user/mvcc keys in a range. If an sstable exceeds\nthis size in multiSSTWriter, we roll over that sstable and create a\nnew one.\n\nEpic: CRDB-8471\nFixes: #67284\n\nRelease note (performance improvement): Reduce the write-amplification\nimpact of rebalances by splitting snapshot sstable files into smaller ones\nbefore ingesting them into Pebble.","shortMessageHtmlLink":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs"}},{"before":"b3cfab24a31f9d232872e027589f6bbe19e07be7","after":"539b69864d2f3709d23ef42ded3c0fdb624ca7b1","ref":"refs/heads/drt-run-2","pushedAt":"2024-08-14T18:48:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"cmd: add drt-run commmand\n\nThis command adds drt-run, a relatively simple go-based binary\nthat concurrently executes some workloads as defined in a config\nYAML file, as well as multiple operation workers that schedule and\nrun operations concurrently. The actual running of workloads\nand operations is done by subprocesses of `workload` and\n`roachtest` managed by this command, mostly to reduce code\ninter-dependencies between the roachtest package and this package.\n\nThis command also supports an http endpoint that shows recent log\nentries from each operation and workload.\n\nEpic: none\n\nRelease note: None","shortMessageHtmlLink":"cmd: add drt-run commmand"}},{"before":"edc9fa3ed058e7d94c27f8573668f8ce60835546","after":"93daeb49eba367c40361686cf637be05b04bb1f0","ref":"refs/heads/multi-sst-splits","pushedAt":"2024-08-14T17:46:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs\n\nPreviously, we'd only create one sstable for all mvcc keys\nin a range when ingesting a rebalance/recovery snapshot into\nPebble. This increased write-amp in Pebble as more sstables\nwould have to be compacted into it (or the sstable then split\ninto smaller ones in Pebble), and had other consequences\nsuch as massive filter blocks in the large singular sstable.\n\nThis change adds a new cluster setting,\nkv.snapshot_rebalance.max_sst_size, that sets the max size of the\nsstables containing user/mvcc keys in a range. If an sstable exceeds\nthis size in multiSSTWriter, we roll over that sstable and create a\nnew one.\n\nEpic: CRDB-8471\nFixes: #67284\n\nRelease note (performance improvement): Reduce the write-amplification\nimpact of rebalances by splitting snapshot sstable files into smaller ones\nbefore ingesting them into Pebble.","shortMessageHtmlLink":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs"}},{"before":"ad59fe62cce9f06023a9b1e40acb9d3889e4ffa6","after":"edc9fa3ed058e7d94c27f8573668f8ce60835546","ref":"refs/heads/multi-sst-splits","pushedAt":"2024-08-14T17:09:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs\n\nPreviously, we'd only create one sstable for all mvcc keys\nin a range when ingesting a rebalance/recovery snapshot into\nPebble. This increased write-amp in Pebble as more sstables\nwould have to be compacted into it (or the sstable then split\ninto smaller ones in Pebble), and had other consequences\nsuch as massive filter blocks in the large singular sstable.\n\nThis change adds a new cluster setting,\nkv.snapshot_rebalance.max_sst_size, that sets the max size of the\nsstables containing user/mvcc keys in a range. If an sstable exceeds\nthis size in multiSSTWriter, we roll over that sstable and create a\nnew one.\n\nEpic: CRDB-8471\nFixes: #67284\n\nRelease note (performance improvement): Reduce the write-amplification\nimpact of rebalances by splitting snapshot sstable files into smaller ones\nbefore ingesting them into Pebble.","shortMessageHtmlLink":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs"}},{"before":"6c785b252277f728afe6d12bc601ffd592c96564","after":"ad59fe62cce9f06023a9b1e40acb9d3889e4ffa6","ref":"refs/heads/multi-sst-splits","pushedAt":"2024-08-14T16:43:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs\n\nPreviously, we'd only create one sstable for all mvcc keys\nin a range when ingesting a rebalance/recovery snapshot into\nPebble. This increased write-amp in Pebble as more sstables\nwould have to be compacted into it (or the sstable then split\ninto smaller ones in Pebble), and had other consequences\nsuch as massive filter blocks in the large singular sstable.\n\nThis change adds a new cluster setting,\nkv.snapshot_rebalance.max_sst_size, that sets the max size of the\nsstables containing user/mvcc keys in a range. If an sstable exceeds\nthis size in multiSSTWriter, we roll over that sstable and create a\nnew one.\n\nEpic: CRDB-8471\nFixes: #67284\n\nRelease note (performance improvement): Reduce the write-amplification\nimpact of rebalances by splitting snapshot sstable files into smaller ones\nbefore ingesting them into Pebble.","shortMessageHtmlLink":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs"}},{"before":"9aff7c877cd32d0e4d4a8f231b0a91cbe7ddeb33","after":"b3cfab24a31f9d232872e027589f6bbe19e07be7","ref":"refs/heads/drt-run-2","pushedAt":"2024-08-14T15:44:44.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"cmd: add drt-run commmand\n\nThis command adds drt-run, a relatively simple go-based binary\nthat concurrently executes some workloads as defined in a config\nYAML file, as well as multiple operation workers that schedule and\nrun operations concurrently. The actual running of workloads\nand operations is done by subprocesses of `workload` and\n`roachtest` managed by this command, mostly to reduce code\ninter-dependencies between the roachtest package and this package.\n\nThis command also supports an http endpoint that shows recent log\nentries from each operation and workload.\n\nEpic: none\n\nRelease note: None","shortMessageHtmlLink":"cmd: add drt-run commmand"}},{"before":"4925af8a9db2360925e338b89a09dafd436b1f61","after":"6c785b252277f728afe6d12bc601ffd592c96564","ref":"refs/heads/multi-sst-splits","pushedAt":"2024-08-13T23:41:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs\n\nPreviously, we'd only create one sstable for all mvcc keys\nin a range when ingesting a rebalance/recovery snapshot into\nPebble. This increased write-amp in Pebble as more sstables\nwould have to be compacted into it (or the sstable then split\ninto smaller ones in Pebble), and had other consequences\nsuch as massive filter blocks in the large singular sstable.\n\nThis change adds a new cluster setting,\nkv.snapshot_rebalance.max_sst_size, that sets the max size of the\nsstables containing user/mvcc keys in a range. If an sstable exceeds\nthis size in multiSSTWriter, we roll over that sstable and create a\nnew one.\n\nEpic: CRDB-8471\nFixes: #67284\n\nRelease note (performance improvement): Reduce the write-amplification\nimpact of rebalances by splitting snapshot sstable files into smaller ones\nbefore ingesting them into Pebble.","shortMessageHtmlLink":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs"}},{"before":"3ab63cd38d48e0b72beb91f670ce8d51b965ec22","after":"4925af8a9db2360925e338b89a09dafd436b1f61","ref":"refs/heads/multi-sst-splits","pushedAt":"2024-08-13T23:36:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs\n\nPreviously, we'd only create one sstable for all mvcc keys\nin a range when ingesting a rebalance/recovery snapshot into\nPebble. This increased write-amp in Pebble as more sstables\nwould have to be compacted into it (or the sstable then split\ninto smaller ones in Pebble), and had other consequences\nsuch as massive filter blocks in the large singular sstable.\n\nThis change adds a new cluster setting,\nkv.snapshot_rebalance.max_sst_size, that sets the max size of the\nsstables containing user/mvcc keys in a range. If an sstable exceeds\nthis size in multiSSTWriter, we roll over that sstable and create a\nnew one.\n\nEpic: CRDB-8471\nFixes: #67284\n\nRelease note (performance improvement): Reduce the write-amplification\nimpact of rebalances by splitting snapshot sstable files into smaller ones\nbefore ingesting them into Pebble.","shortMessageHtmlLink":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs"}},{"before":"fb1a9d573edcf24802046bed5948d2ed868aa2af","after":"3ab63cd38d48e0b72beb91f670ce8d51b965ec22","ref":"refs/heads/multi-sst-splits","pushedAt":"2024-08-13T21:23:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs\n\nPreviously, we'd only create one sstable for all mvcc keys\nin a range when ingesting a rebalance/recovery snapshot into\nPebble. This increased write-amp in Pebble as more sstables\nwould have to be compacted into it (or the sstable then split\ninto smaller ones in Pebble), and had other consequences\nsuch as massive filter blocks in the large singular sstable.\n\nThis change adds a new cluster setting,\nkv.snapshot_rebalance.max_sst_size, that sets the max size of the\nsstables containing user/mvcc keys in a range. If an sstable exceeds\nthis size in multiSSTWriter, we roll over that sstable and create a\nnew one.\n\nEpic: CRDB-8471\nFixes: #67284\n\nRelease note (performance improvement): Reduce the write-amplification\nimpact of rebalances by splitting snapshot sstable files into smaller ones\nbefore ingesting them into Pebble.","shortMessageHtmlLink":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs"}},{"before":null,"after":"3744a1c53179750390695c7eb42358a5927f85bf","ref":"refs/heads/bilal/pebble-master-5627dafd7951","pushedAt":"2024-08-12T19:01:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"go.mod: bump Pebble to 5627dafd7951\n\nChanges:\n\n * [`5627dafd`](https://github.com/cockroachdb/pebble/commit/5627dafd) db: fix compaction bounds expansion to avoid empty key comparisons\n * [`9a4f0c8c`](https://github.com/cockroachdb/pebble/commit/9a4f0c8c) sstable: fix value block closure allocation\n * [`791b3749`](https://github.com/cockroachdb/pebble/commit/791b3749) colblk: add PrefixBytesIter for stateful key synthesis\n * [`3419a647`](https://github.com/cockroachdb/pebble/commit/3419a647) colblk: add UnsafeIntegerSlice microbenchmark\n * [`f1d8c9a0`](https://github.com/cockroachdb/pebble/commit/f1d8c9a0) db: export MakeTrailer\n * [`ba34632e`](https://github.com/cockroachdb/pebble/commit/ba34632e) colblk: add PrefixBytes.SetNextAt\n * [`64a28005`](https://github.com/cockroachdb/pebble/commit/64a28005) colblk: inline SharedPrefix in PrefixBytes.AppendAt\n * [`aacee0a0`](https://github.com/cockroachdb/pebble/commit/aacee0a0) colblk: use pointer receiver for RawBytes, PrefixBytes\n * [`daeeafe0`](https://github.com/cockroachdb/pebble/commit/daeeafe0) colblk: add PrefixBytes.AppendAt\n * [`65445b8a`](https://github.com/cockroachdb/pebble/commit/65445b8a) rowblk: add cockroach microbenchmarks\n * [`cda4471a`](https://github.com/cockroachdb/pebble/commit/cda4471a) colblk: fix UintBuilder's construction of constant column with default\n * [`2e4bf3a6`](https://github.com/cockroachdb/pebble/commit/2e4bf3a6) devtools: use separate module for dev tool dependencies\n * [`62cd2a25`](https://github.com/cockroachdb/pebble/commit/62cd2a25) sstable: extract formatWriterMetadata test helper\n\nRelease note: none.\nEpic: none.","shortMessageHtmlLink":"go.mod: bump Pebble to 5627dafd7951"}},{"before":null,"after":"1da5fb7b9460464c00e5c925fe52386c32d77611","ref":"refs/heads/fix-ctx-use-eventlog","pushedAt":"2024-08-07T18:47:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"server: fix use of context in onStoreDiskSlow\n\nPreviously, we were using the node's start-time\ncontext throughout the life of a store, if the store\nwere to see any disk-slow events. This was problematic\nas tracing spans in the context would get closed, throwing\nerrors around misuse of tracing spans. This change updates\nthe context used to be a newly-minted one off of the node\nitself.\n\nFixes #127729.\n\nEpic: none\n\nRelease note: None","shortMessageHtmlLink":"server: fix use of context in onStoreDiskSlow"}},{"before":"91fb5cd7d456ac523f23fbfd6c9b30893639d3dd","after":"fb1a9d573edcf24802046bed5948d2ed868aa2af","ref":"refs/heads/multi-sst-splits","pushedAt":"2024-08-07T18:06:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs\n\nPreviously, we'd only create one sstable for all mvcc keys\nin a range when ingesting a rebalance/recovery snapshot into\nPebble. This increased write-amp in Pebble as more sstables\nwould have to be compacted into it (or the sstable then split\ninto smaller ones in Pebble), and had other consequences\nsuch as massive filter blocks in the large singular sstable.\n\nThis change adds a new cluster setting,\nkv.snapshot_rebalance.max_sst_size, that sets the max size of the\nsstables containing user/mvcc keys in a range. If an sstable exceeds\nthis size in multiSSTWriter, we roll over that sstable and create a\nnew one.\n\nEpic: CRDB-8471\nFixes: #67284\n\nRelease note (performance improvement): Reduce the write-amplification\nimpact of rebalances by splitting snapshot sstable files into smaller ones\nbefore ingesting them into Pebble.","shortMessageHtmlLink":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs"}},{"before":"ac9fc626d4df7667cff50bc907e28ee0694f280b","after":"91fb5cd7d456ac523f23fbfd6c9b30893639d3dd","ref":"refs/heads/multi-sst-splits","pushedAt":"2024-08-06T20:42:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"itsbilal","name":"Bilal Akhtar","path":"/itsbilal","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/345332?s=80&v=4"},"commit":{"message":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs\n\nPreviously, we'd only create one sstable for all mvcc keys\nin a range when ingesting a rebalance/recovery snapshot into\nPebble. This increased write-amp in Pebble as more sstables\nwould have to be compacted into it (or the sstable then split\ninto smaller ones in Pebble), and had other consequences\nsuch as massive filter blocks in the large singular sstable.\n\nThis change adds a new cluster setting,\nkv.snapshot_rebalance.max_sst_size, that sets the max size of the\nsstables containing user/mvcc keys in a range. If an sstable exceeds\nthis size in multiSSTWriter, we roll over that sstable and create a\nnew one.\n\nEpic: CRDB-8471\nFixes: #67284\n\nRelease note (performance improvement): Reduce the write-amplification\nimpact of rebalances by splitting snapshot sstable files into smaller ones\nbefore ingesting them into Pebble.","shortMessageHtmlLink":"kvserver: split snapshot SSTables for mvcc keys into multiple SSTs"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xOFQyMDowODozNC4wMDAwMDBazwAAAAS6Hre_","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xOFQyMDowODozNC4wMDAwMDBazwAAAAS6Hre_","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOC0wNlQyMDo0Mjo0MS4wMDAwMDBazwAAAASTg7RP"}},"title":"Activity · itsbilal/cockroach"}