Skip to content
This repository has been archived by the owner on Apr 8, 2022. It is now read-only.

colorpicker-selectors stopped working with jQuery 3 #182

Closed
piernik opened this issue Oct 12, 2016 · 1 comment
Closed

colorpicker-selectors stopped working with jQuery 3 #182

piernik opened this issue Oct 12, 2016 · 1 comment
Assignees
Labels

Comments

@piernik
Copy link

piernik commented Oct 12, 2016

In new version colorSelectors are not wokring.
when I change:
this.picker.find('.colorpicker-selectors').show();
to
this.picker.find('.colorpicker-selectors').css('display','block');
It is ok.

I'm using jQuery 3.1.1

@itsjavi itsjavi added the bug label Dec 28, 2016
@itsjavi itsjavi self-assigned this Dec 28, 2016
@itsjavi
Copy link
Owner

itsjavi commented Dec 28, 2016

@piernik That's an issue with jQuery 3. The show() hide() and toggle() method behaviors have been changed:

https://jquery.com/upgrade-guide/3.0/#breaking-change-show-hide-and-toggle-methods-now-respect-more-stylesheet-changes

This could be solved in a future version using state-classes (like .hidden) instead of relying on jQuery's visibility methods.

Meanwhile please stick to jQuery < 3 if possible.

@itsjavi itsjavi changed the title ColorSelectors stopped working colorpicker-selectors stopped working with jQuery 3 Dec 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants