fix(types): typing issues on DTS generation

itsjavi · Sep 27, 2023 · f3865c9 · f3865c9
1 parent 4b90203
commit f3865c9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 15 deletions.
diff --git a/commitlint.config.js b/commitlint.config.js
@@ -31,7 +31,7 @@ module.exports = {
     ],
     // 'scope-empty': [2, 'never'],
     'scope-enum': [
-      2,
+      1,
       'always',
       [
         'general',

diff --git a/packages/storylite/src/services/renderer/react.tsx b/packages/storylite/src/services/renderer/react.tsx
@@ -6,17 +6,17 @@ const defaultDecorator: SLDecorator<any> = (Story, context) => {
 }
 
 function applyDecorators(
-  StoryComponent: React.FC,
+  StoryComponent: SLFunctionComponent,
   decorators: SLDecorator[],
   context: SLDecoratorContext,
-) {
+): SLFunctionComponent {
   return decorators.reduce(
     (DecoratedStory, decorator) =>
       function DecoratedWithDecorator() {
         return decorator(DecoratedStory as SLFunctionComponent, context)
       },
     StoryComponent,
-  )
+  ) as SLFunctionComponent
 }
 
 export function renderStory(storyComponent: SLFunctionComponent, story: StoryWithId) {

diff --git a/packages/storylite/src/types/components.ts b/packages/storylite/src/types/components.ts
@@ -1,4 +1,4 @@
-import type { ComponentProps } from 'react'
+import type { ComponentProps, ReactNode } from 'react'
 
 import type { SLObject } from './core'
 
@@ -10,17 +10,9 @@ export type SLElement<P extends SLObject = {}> = {
   key: string | number | null
 }
 
-export type SLNode =
-  | null
-  | undefined
-  | string
-  | number
-  | boolean
-  | SLElement<any>
-  | Iterable<SLNode>
-// | SLFunctionComponent<any>
+export type SLNode = ReactNode
 
-export type SLFunctionComponent<P extends SLObject = {}> = React.FC<P>
+export type SLFunctionComponent<P = {}> = React.FC<P>
 
 export type SLComponentProps<T> = T extends
   | React.ComponentType<infer P extends SLObject>