You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are currently using react-native-video-controls and would like to add our own custom controls and information that should only be visible when the controls are visible.
Rather than add our own onPress and try to keep it in sync with the controlTimeout, it would be great to hook in to the library and know when the controls are shown and paused.
Proposal:
Inside _toggleControls add conditional calls to this.props.onControlShow and this.props.onControlHide
Thoughts?
If acceptable, I'll make a PR and update the README
The text was updated successfully, but these errors were encountered:
The problem is that you are only taking the props on the constructor so if I want to use dynamic variables in the function I can't (without re-rendering the component).
The way I worked around it now is by doing this videoRef.current.events.onShowControls = onShowControls; but it is ugly :)
We are currently using
react-native-video-controls
and would like to add our own custom controls and information that should only be visible when the controls are visible.Rather than add our own
onPress
and try to keep it in sync with thecontrolTimeout
, it would be great to hook in to the library and know when the controls are shown and paused.Proposal:
Inside
_toggleControls
add conditional calls tothis.props.onControlShow
andthis.props.onControlHide
Thoughts?
If acceptable, I'll make a PR and update the
README
The text was updated successfully, but these errors were encountered: