Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Support non-Java users for whitelist #448

Open
kaysond opened this issue Jul 10, 2024 · 3 comments
Open

[Request] Support non-Java users for whitelist #448

kaysond opened this issue Jul 10, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@kaysond
Copy link

kaysond commented Jul 10, 2024

I want to use env vars in docker-minecraft-server to manage my whitelist, but it makes the container fail to start up because mc-image-helper chokes on the usernames and UUIDs provided by floodgate. It looks like the API endpoint is hardcoded to minecraft here:

urlBuilder.resolve("/api/player/minecraft/{input}", input)

playerdb does support xbox and steam accounts via dedicated endpoints, though there seems to be some conversion needed for the floodgate uuid (see https://wiki.geysermc.org/floodgate/faq/#obtaining-uuids-for-floodgate-players)

It would probably need some kind of marker in the env var to indicate a different account type, and maybe there's a reason this can't be supported, but it would be nice to have!

@itzg
Copy link
Owner

itzg commented Jul 10, 2024

Thanks, I had only used/tested with Java usernames of players connected to Xbox user.

The feature gap wasn't intended. Yes, perhaps a prefix like "xbox:" or "floodgate:" on the username could trigger the new lookup?

@itzg itzg added the enhancement New feature or request label Jul 10, 2024
@kaysond
Copy link
Author

kaysond commented Jul 11, 2024

Thanks, I had only used/tested with Java usernames of players connected to Xbox user.

The feature gap wasn't intended. Yes, perhaps a prefix like "xbox:" or "floodgate:" on the username could trigger the new lookup?

Yeah I was thinking something like that. The env var makes things way easier than having to manually lookup/convert the floodgate names to UUIDs!

FYI - one complication is that it seems you have to specify the user's name with the floodgate prefix. It defaults to . but can be changed in the config:

image
Source: https://wiki.geysermc.org/geyser/faq/

@kaysond
Copy link
Author

kaysond commented Jul 11, 2024

There also seems to be some conversion of spaces in a gamertag, for example, to underscores. But in playerdb, it returns the name without spaces (even if you send the request with a space)

@itzg itzg moved this to To do in Docker Minecraft Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

2 participants