Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error pages for 500/504/etc. #176

Closed
Discookie opened this issue Sep 20, 2018 · 2 comments
Closed

Error pages for 500/504/etc. #176

Discookie opened this issue Sep 20, 2018 · 2 comments

Comments

@Discookie
Copy link

(Moved from #173)

The site currently doesn't have proper error pages for most errors.
I think instead of the raw HTTP codes/one-liners, it should give a bit of explanation:

  • for 503/504 one that would explain that the servers are overloaded
  • for 500 one that would point them to make an issue here
  • etc etc.

I know some errors (like 404) do have their own pages, but I think all but the worst errors should be caught before the user sees them.

@omarroth
Copy link
Contributor

omarroth commented Sep 20, 2018

Proposed errors:

For 503/504: Unfortunately this is an error provided by the host, I don't think there's much I can do to change it.
For 500,other fatal errors: "Looks like you've found a bug in Invidious. Feel free to open an issue here or send an email to omarroth@protonmail.com"
For 404: YouTube actually redirects to / instead of showing 404, I'd be open to doing that instead

I think most errors are caught before the user sees them, although sometimes an error can crop up where I didn't expect it, so there's no handling for it. I think those are getting fewer, as I've tried to make errors non-fatal (leaving a video out of search if Invidious can't extract info from it for example, or leaving channels empty instead of 500).

@omarroth
Copy link
Contributor

Added proposed error messages with dfd17bd.

@omarroth omarroth closed this as completed Mar 8, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants