Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Set DASH and HLS by default #4847

Open
unixfox opened this issue Aug 15, 2024 · 10 comments
Open

[Enhancement] Set DASH and HLS by default #4847

unixfox opened this issue Aug 15, 2024 · 10 comments
Labels
enhancement Improvement of an existing feature

Comments

@unixfox
Copy link
Member

unixfox commented Aug 15, 2024

Since YouTube has removed hd720: #4759, the only default resolution available is 480p aka medium.

My feeling is that YouTube is soon going to shutdown the last combined video and sound medium resolution. And users will be left with no video stream to play unless they switch to DASH.

This is why I would like to propose to seriously switch to DASH by default.

Ideally, we should do it when:

This will solve the long time issue of people asking why 1080p is not available and things like this. Non JS users will still have medium quality working until it's no longer available.

For the public instances, we could still allow some that do not offer DASH but listed in a separate section and not listed on https://api.invidious.io. We don't really want to confuse the users with reduced features.

@unixfox unixfox added the enhancement Improvement of an existing feature label Aug 15, 2024
@syeopite
Copy link
Member

The current HLS implementation from #4118 actually requires proxying.

It has been awhile since I last worked on it but if I recall correctly there was some issues with getting HLS to work without proxying.

@charonfaustinus
Copy link

charonfaustinus commented Aug 16, 2024

medium is actually 360p with very low bitrate. Unwatchable when there's a lot of movement in video.

Also, I've noticed that when I use LibRedirect add-on to redirect all the embed youtube iframes to invidious. The HLS user option doesn't apply, and it only loads medium 360p quality. It'll be nice if we have HLS option set by default.

It has been awhile since I last worked on it but if I recall correctly there was some issues with getting HLS to work without proxying.

Maybe *.googlevideo.com doesn't allow CORS?

@syeopite
Copy link
Member

The HLS implementation has not been merged yet

@Feodor2

This comment was marked as off-topic.

@charonfaustinus
Copy link

And there is no way to set back medium

Set by default doesn't mean it'll be removed from the setting. Out of the box, nobody wants to watch 360p youtube crap encoded file. If somehow you can't use hls/dash, there should be a setting to fall back to medium.

This topic is a discussion about setting hls/dash by default. NOT removing it entirely.

@Feodor2

This comment was marked as off-topic.

@artshevtsov

This comment has been minimized.

@unixfox
Copy link
Member Author

unixfox commented Aug 31, 2024

@artshevtsov please open a separate issue you are offtopic. This is about setting DASH by default in invidious.

@ashley0143
Copy link

wasnt HLS disabled on firefox mobile?

https://bugzilla.mozilla.org/show_bug.cgi?id=1911651

@Fijxu
Copy link
Contributor

Fijxu commented Oct 28, 2024

piped-proxy has been the recommended solution for proxying the video stream on public instances: TeamPiped/piped-proxy#111 otherwise most public instances will collapse under the load.

There is one really annoying problem on piped-proxy that doesn't happen with https://github.com/TeamPiped/http3-ytproxy on any Chromium based browser which is that is not able to reproduce any video using DASH, but Firefox and it's forks are able to reproduce DASH while using piped-proxy as a videoplayback proxy.

This happens on PC and Android. Chrome for PC and Android aren't able to reproduce the video without having the developers tools open. Firefox for PC and Android are able to reproduce the video just fine.

https://s.ayaya.beauty/xus

In the last seconds, the video starts to play instantly after I attach the DevTools inspect to the Browser making this hard to debug. I used Stock Google Chrome on both devices but this happens on Bromite, Cromite and Mulch

https://s.ayaya.beauty/xus

Same as Android Chrome. If I open the Developer Tools the video starts to play instantly.

I would like to migrate to piped-proxy but I can't if this annoying bug is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature
Projects
Status: Invidious features
Status: To Do - Front-end
Development

No branches or pull requests

7 participants