Extractors: Don't error if AuthorId does not exist #3869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamantazFox
reviewed
Jun 9, 2023
SamantazFox
reviewed
Jul 14, 2023
ChunkyProgrammer
force-pushed
the
fix-searches-where-no-author-id
branch
from
6fb9828
to
19e6425
Compare
ChunkyProgrammer
force-pushed
the
fix-searches-where-no-author-id
branch
2 times, most recently
from
eeefc92
to
6e1ebdc
Compare
ChunkyProgrammer
force-pushed
the
fix-searches-where-no-author-id
branch
from
6e1ebdc
to
19b7fed
Compare
ChunkyProgrammer
changed the title
1 task
SamantazFox
approved these changes
Dec 6, 2023
SamantazFox
added
the
need-testing
ChunkyProgrammer
force-pushed
the
fix-searches-where-no-author-id
branch
from
9c8bf9b
to
f1edb1d
Compare
SamantazFox
added
in-testing
|
I wasn't able to find pages (search results, videos, etc) where I could see the fix. All of the search queries mentioned in the issues linked above don't show the problematic search results, and all the videos are now blocked (likely due to being from "Topic" channels). |
|
This video U6EqIzLCvZQ and this search result is still able to reproduce this redirect.invidious.io/search?q=cdr+thats+cdr |
SamantazFox
added
ready
and removed
in-testing
|
Thanks for the test cases @syeopite! This works like a charm! |
SamantazFox
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3812
closes #2530
closes #4133
closes #3766
closes #3349
Some playlist author's don't have a YouTube channel (I'm guessing this is mainly for albums edit: it's also the case for some movies on youtube which can appear in the related streams section)