Skip to content
This repository has been archived by the owner on Jul 21, 2024. It is now read-only.

[Enhancement] Use the IETF draft-29 of HTTP/3 #16

Open
FireMasterK opened this issue Apr 8, 2021 · 8 comments
Open

[Enhancement] Use the IETF draft-29 of HTTP/3 #16

FireMasterK opened this issue Apr 8, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@FireMasterK
Copy link

Is your enhancement request related to a problem? Please describe.
Yes, lsquic causes a lot of signal 11 killed errors, so I thought this would be worth a shot to fix the issue

Describe the solution you'd like
Usage of the IETF draft instead of Google's draft

Describe alternatives you've considered
N/A

Additional context
Google Chrome uses the IETF drafts by default now

Relevant code at

LibLsquic::Version::Lsqver050,

@unixfox
Copy link
Member

unixfox commented Apr 8, 2021

Well the issue is that HTTP3 is not supported by crystal and not even HTTP2: crystal-lang/crystal#2125 (comment)

@FireMasterK
Copy link
Author

No language has inbuilt support for HTTP/3 currently. There are only implementations currently as they're just drafts currently. However, this is going to change soon when the v1 draft RFC is released.

It's also worth noting that lsquic and chromium are the only two network stacks with support for gquic

@B0pol
Copy link

B0pol commented Jun 18, 2021

The RFCs have been published

@FireMasterK
Copy link
Author

This should be a one-line change from what I can see.

Changing LibLsquic::Version::Lsqver050 to LibLsquic::Version::LsqverId29 in

LibLsquic::Version::Lsqver050,
.

@syeopite
Copy link
Member

Was that even implemented in litespeed quic v2.18?

@FireMasterK
Copy link
Author

Last time I checked, it was in the latest release a few months ago.

So yes, it's likely there and hence why there's bindings for it.

@SamantazFox
Copy link
Member

This should be a one-line change from what I can see.

Changing LibLsquic::Version::Lsqver050 to LibLsquic::Version::LsqverId29 in

LibLsquic::Version::Lsqver050,
.

I wish it was that easy. But in order to do that, we need to upgrade lsquic, and upgrade the C bindings in lsquic.cr

@unixfox
Copy link
Member

unixfox commented Jun 19, 2021

Last time I checked, it was in the latest release a few months ago.

So yes, it's likely there and hence why there's bindings for it.

It didn't exist at the time of lsquic 2.18: https://github.com/litespeedtech/lsquic/tree/v2.18.1/src/liblsquic/client.cr#L200

@unixfox unixfox transferred this issue from iv-org/invidious Apr 17, 2022
@unixfox unixfox moved this to To Do - Backend / YT scraper in Todo - Invidious Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: To Do - Backend / YT scraper
Development

No branches or pull requests

5 participants