Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customized SCSS/CSS #19

Open
9 tasks
ivanhercaz opened this issue Dec 10, 2019 · 3 comments
Open
9 tasks

Customized SCSS/CSS #19

ivanhercaz opened this issue Dec 10, 2019 · 3 comments
Labels
documentation Improvements or additions to documentation enhancement new feature or request (general) good first issue Good for newcomers priority:high Any issue with a high priority.

Comments

@ivanhercaz
Copy link
Owner

The user should be able to change the colors of the theme without modifying the theme itself. Thus it is very important to implement a way to use a customized stylesheet. It should address two possible situations:

User that prefers to use CSS directly

If the user will prefer to use CSS dircetly, it should have instructions about how to modify each thing in a custom stylesheet. The user should know the the pros and cons of this way:

  • Pros. You can edit and use directly your CSS.
  • Cons. It may be more complex to customize all Buruma.

User that prefers to use SCSS

If the user will prefer to use SCSS, the user would need to know a good way to convert SCSS into a CSS file. The user should know the pros and cons of this way:

  • Pros. User can benefit of all the SCSS extension.
  • Cons. User will need to convert SCSS to CSS to use it.
  • Pros. Related with the cons, the process to build a CSS file from the SCSS might be easier investing a bit of time with the installation and configuring of some packages and scripts (take a look at package.json).
  • Cons. Whatever the user uses, the user will need an extra configuration to work with SCSS.

Development

  • Add way to integrate CUSTOM_CSS in base.html template: if CUSTOM_CSS exists, then add this <link ... />.

Documentation

  • Document CUSTOM_CSS.
    • Pros and cons.
    • How-to add modifications to the theme.
  • Document CUSTOM_SCSS.
    • Pros and cons.
    • How-to add modifications to the theme.
    • How-to build the CSS.
    • An easy solution: show how Buruma does it internally and how the user can apply it to its own site.
@ivanhercaz ivanhercaz added enhancement new feature or request (general) priority:high Any issue with a high priority. documentation Improvements or additions to documentation good first issue Good for newcomers labels Dec 10, 2019
@ivanhercaz
Copy link
Owner Author

I think the plugin pelican-assets is very interesting for this issue.

@ivanhercaz
Copy link
Owner Author

@maciejmatczak, do you need urgently this to work with your site?

@maciejmatczak
Copy link

@ivanhercaz, made some dirty workaround :) with CUSTOM_CSS, I am good for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement new feature or request (general) good first issue Good for newcomers priority:high Any issue with a high priority.
Projects
None yet
Development

No branches or pull requests

2 participants