Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow's Python version upgrade #57

Open
jjw24 opened this issue Sep 7, 2023 · 3 comments
Open

Flow's Python version upgrade #57

jjw24 opened this issue Sep 7, 2023 · 3 comments

Comments

@jjw24
Copy link

jjw24 commented Sep 7, 2023

Hi there, how's it going.

Current Python version used by Flow is v3.8.9, we are looking to upgrade it to v3.11.4 in the upcoming release, in around a week's time.

This plugin has failed the v3.11.4 plugin test so thought I give you a heads up about this upgrade and see if this can be resolved. You can repro the error by using the pre-release version of flow here with your plugin: https://github.com/Flow-Launcher/Prereleases/releases.

Have you had a chance to implement Garulf's suggestion here #39?

@ivanipenburg
Copy link
Owner

Hi, thanks for letting me know!

I think the errors with the regex package actually stem from Python 3.8 being required, so hopefully updating this should solve a lot. I'll try to find some time soon to upgrade.

@jjw24
Copy link
Author

jjw24 commented Sep 13, 2023

No problem. FYI, once you are done, you can do a release but mark it as prerelease, which should avoid the plugin updater from picking it up until the new release with the python upgrade is out.

This also allows you to test your new plugin version against the flow's prerelease version by pm install url-to-zip

@ivanipenburg
Copy link
Owner

Do you know if there are any differences between file read/write permissions between a Python plugin and an executable plugin? The code needs to read from a token.json file, which it has written previously, but it gets a random TypeError: Object of type UnknownApiNameOrVersion is not JSON serializable error when running the plugin as an executable. Running the plugin as a Python plugin works perfectly fine.

Is there any other way to store something like a token over sessions in a FlowLauncher plugin, without having to write files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants