Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ivy.deform_conv2d #21187

Closed
themaigod opened this issue Aug 2, 2023 · 4 comments
Closed

ivy.deform_conv2d #21187

themaigod opened this issue Aug 2, 2023 · 4 comments
Assignees
Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task

Comments

@themaigod
Copy link
Contributor

themaigod commented Aug 2, 2023

Why should this be implemented?
As discussion in #20138, deformable convolution is a popular and common operation. Here is the reason why I think it should be added as an experimental api:

  • 3+ of the native frameworks have this function (Pytorch (in torchvision), mindspore, paddlepaddle)
  • it's an NN-related function and should be as efficient as possible (official implementations in native frameworks have advantage in speed)
  • it's needed for a complex/long frontend function implementation

Links to native framework implementations

Link to Third Party Implementations only by Python which are complex and low efficiency
-PyTorch
-TensorFlow

Link to the paper which released this op

@themaigod themaigod added Ivy API Experimental Run CI for testing API experimental/New feature or request Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task labels Aug 2, 2023
@themaigod
Copy link
Contributor Author

themaigod commented Aug 2, 2023

@themaigod
Copy link
Contributor Author

themaigod commented Aug 11, 2023

  • Create the API in ivy functional api
  • Create the backend implementation in PyTorch for it
  • Create the backend implementation in Paddlepaddle for it
  • Create the backend implementation in MXNet for it
  • Write tests for it

@AnnaTz
Copy link
Contributor

AnnaTz commented Aug 14, 2023

Thanks for the suggestion! I have added this to our ToDo list and linked your PR to the new issue!

@AnnaTz AnnaTz closed this as completed Aug 14, 2023
@themaigod
Copy link
Contributor Author

Thanks for the suggestion! I have added this to our ToDo list and linked your PR to the new issue!

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task
Projects
None yet
Development

No branches or pull requests

2 participants