feat : Implemented ifftshift and test #23882
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
ivy-leaves
added
the
JAX Frontend
VaishnaviMudaliar
changed the title
VaishnaviMudaliar
changed the title
|
Hey @jshepherd01 , please do review my PR and let me know if any changes required, thanks 😊 |
|
Hi @VaishnaviMudaliar, sorry about this but I think I shouldn't have been assigned to this issue as my contract at Ivy finished at the end of last week. As such, I'm unassigning myself now and hopefully someone else will be along shortly to review this properly. |
Alright, thanks anyway |
|
Hey @bipinKrishnan please do review my PR and let me know about the further changes needed, thanks!😊 |
|
Hey @VaishnaviMudaliar, could you please fix the conflicts and push again? |
|
I'll do it right away |
|
Hey @bipinKrishnan , i have resolved the conflicts, please have a look and let me know if further changes are required, thanks! 😊 |
|
Hey @VaishnaviMudaliar, seems like you've rebased incorrectly. You could see that the test implementation you added is missing some code. Can you please correct it? Let me know if you face any issues. Thanks! |
| dtype_and_x, backend_fw, frontend, test_flags, fn_tree, on_device | ||
| ): | ||
| input_dtype, arr = dtype_and_x | ||
|
|
There was a problem hiding this comment.
The test function is missing some code here
| helpers.test_frontend_function( | ||
| input_dtypes=input_dtype, | ||
| frontend=frontend, | ||
| backend_to_test=backend_fw, | ||
| test_flags=test_flags, | ||
| fn_tree=fn_tree, | ||
| on_device=on_device, | ||
|
|
There was a problem hiding this comment.
These changes are not related to the function you added, so you could undo these changes.
|
@bipinKrishnan I have added the missing code and made the changes, please do check and let me know 🙂 |
|
Hey, still there are same changes not related to your changes, you could check this in the "Files changed" tab at the top, please undo these. Also, you should install pre-commit in your system so that the linting is done automatically before pushing the code, currently the lint tests are failing due to not doing this. Thanks! |
|
Hi! @bipinKrishnan , I have run the pre-commit and also removed the unwanted code, please let me know if anymore changes are needed . Thanks! |
|
Hey @bipinKrishnan , while making the above mentioned changes , I had accidentally deleted the code for an already implemented function , I apologize for doing so , however , i have added the code back . I would request you to please check the PR . Thanks for your patience :) |
|
Hey @bipinKrishnan , please do review the PR for the made changes, thanks!😊 |
|
|
||
| # If axes is None, shift all axes | ||
| if axes is None: | ||
| axes = list(range(ivy.ndims(x))) |
There was a problem hiding this comment.
The tests are failing because ivy doesn't have ndims attribute.
There was a problem hiding this comment.
I guess I missed that while reading the docs , however , I have changed it to len(shape)
Since Ivy's documentation does not have function 'ndim' , i am using the length of the shape instead.
|
Hey @bipinKrishnan , I have changed the code as suggested, I would request you to please review the PR, thanks! |
|
Hey @bipinKrishnan , please do review the PR for the changes made! Thank you!😊 |
|
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days. |
|
@joaozenobio please review the PR , its been very long since i last requested , thanks! |
PR Description
Related Issue
Close #23801
Checklist
Socials: