Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added swapaxes instance method and test function for it #26513

Merged
merged 2 commits into from
Oct 28, 2023
Merged

feat: added swapaxes instance method and test function for it #26513

merged 2 commits into from
Oct 28, 2023

Conversation

mcnugets
Copy link
Contributor

@mcnugets mcnugets commented Oct 3, 2023 •
edited
Loading

PR Description

Added swapaxes instance method and test function for it

Related Issue

Closes #26512

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

@ivy-leaves ivy-leaves added the JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist label Oct 3, 2023
@mcnugets
Copy link
Contributor Author

mcnugets commented Oct 9, 2023

Hello @saeedashrraf, can you please review my PR? Thank you

saeedashrraf
saeedashrraf suggested changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@saeedashrraf saeedashrraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mcnugets, I apologize for the delay, it seems like your PR slipped under the radar somehow. It looks like the tests are failing for the paddle backend, can you try and address this?

Thanks!

@mcnugets
Copy link
Contributor Author

Thank you for the review @saeedashrraf, i will what I can do

@github-actions
Copy link
Contributor

Thank you for this PR, here is the CI results:

This pull request does not result in any additional test failures. Congratulations!

@mcnugets
Copy link
Contributor Author

@saeedashrraf, Hello please confirm if I still need to address the issue, thank you.

@NripeshN NripeshN merged commit 62101f4 into ivy-llc:main Oct 28, 2023
267 of 269 checks passed
@mcnugets mcnugets deleted the my_branch branch October 28, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saeedashrraf saeedashrraf Awaiting requested review from saeedashrraf

Assignees

@saeedashrraf saeedashrraf

Labels
JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

swapaxes
4 participants
@mcnugets @saeedashrraf @NripeshN @ivy-leaves