fix: Fix broken module converter tests #27089
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
|
Hey @hmahmood24 I was the one who made that PR. Sorry, I missed it. Thank you for correcting it 👍. |
hmahmood24
changed the title
No worries at all @Sai-Suraj-27 😄 |
|
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
There was a problem hiding this comment.
Great catch, feel free to merge, thanks @hmahmood24 😄
(apologies for not noticing that when I reviewed the PR)
PR Description
The changes made in this commit broke the module converter tests and also some of the module tests in the transpiler. I guess that PR forgot to make this small change as well which fixes all the aforementioned tests.
Related Issue
Closes #
Checklist
Socials