-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Frontend Failing Test: torch - blas_and_lapack_ops.cholesky and torch - linalg.cholesky #28766
Comments
It seems like there are two cholesky function under the ivy/functional/frontend/torch. one is in ivy/functional/frontends/torch/linalg.py#L14, and the other is in /ivy/functional/frontends/torch/blas_and_lapack_ops.py#L93. Both frontend function uses the same ivy function ivy.cholesky, and the tests for both frontend functions fail for now for the same "AssertionError: returned dtype = float32, ground-truth returned dtype = float64" reason. |
though for the similiar ivy/functional/frontends/torch/linalg/cholesky_ex frontend function, it false with "AttributeError: 'list' object has no attribute 'T'" instead. which seems to be caused by the extra error check in the cholesky_ex function |
it seems like for torch, even if the input dtype is float32, the output dtype is expected to be float64, instead of keeping at float32 like what ivy did. |
I found a related new failure from the frontend test of torch.linalg.cholesky that is different: |
No description provided.
The text was updated successfully, but these errors were encountered: