Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Frontend Failing Test: torch - blas_and_lapack_ops.svd #28769

Open
Daniel4078 opened this issue Jun 20, 2024 · 4 comments · May be fixed by #28770 or #28829
Open

Fix Frontend Failing Test: torch - blas_and_lapack_ops.svd #28769

Daniel4078 opened this issue Jun 20, 2024 · 4 comments · May be fixed by #28770 or #28829
Labels
Sub Task a sub task which is stemming from a ToDo list issue

Comments

@Daniel4078
Copy link
Contributor

No description provided.

@Daniel4078 Daniel4078 added the Sub Task a sub task which is stemming from a ToDo list issue label Jun 20, 2024
@Daniel4078
Copy link
Contributor Author

Daniel4078 commented Jun 20, 2024

Now the failing tests shows that the ground truth is somehow thought to be all zeros, while the parameters of some = False, compute = False cause the full_matrices to be computed while zero-filled tensors should be returned for U and V (according to torch documentation https://pytorch.org/docs/stable/generated/torch.svd.html)

@Daniel4078
Copy link
Contributor Author

But according to the same documentation, the output should be a tuple of (U, S, V), instead of the current supposed ground truth of (U, V) (as shown here https://github.com/Transpile-AI/ivy/actions/runs/9589504921/job/26443403485#step:6:127). So I believe the current implementations of the torch.svd and the test are both wrong.

@Daniel4078
Copy link
Contributor Author

Currently, both svd function in torch frontend have certain behaviors unimplemented, so will start working on that first.

@Daniel4078
Copy link
Contributor Author

Also found that the backend implementation of torch.linear_algebra.svd does not produce the namedtuple output of (U,S,Vh) as described by the ivy function svd when compute_uv is false.

@Daniel4078 Daniel4078 linked a pull request Jun 20, 2024 that will close this issue
5 tasks
@Daniel4078 Daniel4078 linked a pull request Sep 28, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sub Task a sub task which is stemming from a ToDo list issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant