Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fft functions to Jax frontend #4613

Open
fnhirwa opened this issue Sep 19, 2022 · 5 comments
Open

Add Fft functions to Jax frontend #4613

fnhirwa opened this issue Sep 19, 2022 · 5 comments
Assignees
Labels
hacktoberfest hacktoberfest JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist ToDo A ToDo list of tasks

Comments

@fnhirwa
Copy link
Contributor

fnhirwa commented Sep 19, 2022

Add Fft functions to Jax frontend

_

Please keep in mind that the proper way to link an issue to this list is to comment "- [ ] #issue_number" while the issue's title only includes the name of the function you've chosen.
_

The main file paths where these functions are likely to be added are:

ivy/functional/frontends/jax/numpy/fft.py
ivy_tests/test_ivy/test_frontends/test_jax/test_numpy/test_fft.py

@fnhirwa fnhirwa closed this as completed Sep 19, 2022
@fnhirwa fnhirwa added Extension JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist ToDo A ToDo list of tasks labels Sep 19, 2022
@fnhirwa fnhirwa reopened this Sep 19, 2022
@ivy-llc ivy-llc deleted a comment from KaiGarcia Nov 5, 2022
@ivy-llc ivy-llc deleted a comment from airpods69 Nov 7, 2022
@ivy-llc ivy-llc deleted a comment from airpods69 Nov 9, 2022
@sreegandh804 sreegandh804 added Ivy API Experimental Run CI for testing API experimental/New feature or request and removed Experimental labels Nov 18, 2022
@fnhirwa fnhirwa self-assigned this Nov 20, 2022
@ivy-llc ivy-llc deleted a comment from gurumoorty-s Mar 10, 2023
@ManoBharathi93
Copy link
Contributor

ManoBharathi93 commented Apr 18, 2023

  • fft
  • fft2
    Started working on this two function.

@ManoBharathi93
Copy link
Contributor

I have implemented this function but I don't understand why it's not passing the github workflow. can anyone help me with this ? I know the fft and ifft logic I can do it from scratch.

import jax.numpy.fft as jax_fft
import ivy.numpy as ivy_np

def fft(x):
    # convert input array to Jax array
    x_jax = ivy_np.asarray(x)
    # calculate FFT using Jax
    y_jax = jax_fft.fft(x_jax)
    # convert output array to Ivy array
    y = ivy_np.asarray(y_jax)
    return y

def ifft(x):
    # convert input array to Jax array
    x_jax = ivy_np.asarray(x)
    # calculate inverse FFT using Jax
    y_jax = jax_fft.ifft(x_jax)
    # convert output array to Ivy array
    y = ivy_np.asarray(y_jax)
    return y

@AnnaTz AnnaTz changed the title Add jax.numpy.fft functions to Jax frontend Add Fft functions to Jax frontend May 4, 2023
@AnnaTz AnnaTz removed the Ivy API Experimental Run CI for testing API experimental/New feature or request label May 4, 2023
@ivy-llc ivy-llc deleted a comment from farhanoktvn May 24, 2023
@ivy-llc ivy-llc deleted a comment from alexkoziell Jul 25, 2023
@ivy-llc ivy-llc deleted a comment from hnhparitosh Jul 26, 2023
@ivy-llc ivy-llc deleted a comment from hnhparitosh Aug 1, 2023
@AbdullahSabry
Copy link
Contributor

@shovan777
Copy link
Contributor

@ivy-leaves ivy-leaves assigned Ishticode and unassigned fnhirwa Aug 22, 2023
@abdllahdev
Copy link
Contributor

@ivy-llc ivy-llc deleted a comment from aabuzaid2 Sep 6, 2023
@ivy-llc ivy-llc deleted a comment from AbdullahSabry Sep 6, 2023
@ivy-llc ivy-llc deleted a comment from roudik Sep 19, 2023
@ivy-llc ivy-llc deleted a comment from bavishhh Sep 19, 2023
@ivy-llc ivy-llc deleted a comment from hnhparitosh Sep 19, 2023
@ivy-llc ivy-llc deleted a comment from SenayGe Sep 19, 2023
@ivy-llc ivy-llc deleted a comment from VaishnaviMudaliar Sep 19, 2023
@a0m0rajab a0m0rajab added the hacktoberfest hacktoberfest label Sep 25, 2023
@ivy-llc ivy-llc deleted a comment from uggoprince Sep 25, 2023
@ivy-llc ivy-llc deleted a comment from AwkNinja Sep 27, 2023
@ivy-llc ivy-llc deleted a comment from AwkNinja Sep 29, 2023
@ivy-llc ivy-llc deleted a comment from zerodoxxx Oct 9, 2023
@ivy-llc ivy-llc deleted a comment from GOW7527 Oct 10, 2023
@ivy-llc ivy-llc deleted a comment from jyjoshi Nov 15, 2023
@ivy-llc ivy-llc locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest hacktoberfest JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist ToDo A ToDo list of tasks
Projects
None yet
Development

No branches or pull requests

10 participants