From a3998981940a8c2cec5c9ccf24d84285cffef681 Mon Sep 17 00:00:00 2001 From: Sam Armstrong <88863522+Sam-Armstrong@users.noreply.github.com> Date: Mon, 26 Feb 2024 14:33:57 +0000 Subject: [PATCH] fix: Variable frontend methods setting ivy_array to frontend tensor --- .../tensorflow/python/ops/resource_variable_ops.py | 13 ++++++++++++- ivy/functional/frontends/tensorflow/variable.py | 7 +++++-- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/ivy/functional/frontends/tensorflow/python/ops/resource_variable_ops.py b/ivy/functional/frontends/tensorflow/python/ops/resource_variable_ops.py index 1ac276f9d2224..03ce4f5103d3f 100644 --- a/ivy/functional/frontends/tensorflow/python/ops/resource_variable_ops.py +++ b/ivy/functional/frontends/tensorflow/python/ops/resource_variable_ops.py @@ -3,4 +3,15 @@ class ResourceVariable(tf_frontend.Variable): - pass + def __repr__(self): + return ( + repr(self._ivy_array).replace( + "ivy.array", + "ivy.functional.frontends.tensorflow.python.ops.resource_variable_ops.ResourceVariable", + )[:-1] + + ", shape=" + + str(self._ivy_array.shape) + + ", dtype=" + + str(self._ivy_array.dtype) + + ")" + ) diff --git a/ivy/functional/frontends/tensorflow/variable.py b/ivy/functional/frontends/tensorflow/variable.py index b580ba13d89e3..77f0053f6bf08 100644 --- a/ivy/functional/frontends/tensorflow/variable.py +++ b/ivy/functional/frontends/tensorflow/variable.py @@ -58,6 +58,7 @@ def assign(self, value, use_locking=None, name=None, read_value=True): as_array=False, ) self._ivy_array = value._ivy_array + return self def assign_add(self, delta, use_locking=None, name=None, read_value=True): ivy.utils.assertions.check_equal( @@ -65,7 +66,8 @@ def assign_add(self, delta, use_locking=None, name=None, read_value=True): self.shape, as_array=False, ) - self._ivy_array = tf_frontend.math.add(self._ivy_array, delta._ivy_array) + self._ivy_array = ivy.add(self._ivy_array, delta._ivy_array) + return self def assign_sub(self, delta, use_locking=None, name=None, read_value=True): ivy.utils.assertions.check_equal( @@ -73,7 +75,8 @@ def assign_sub(self, delta, use_locking=None, name=None, read_value=True): self.shape, as_array=False, ) - self._ivy_array = tf_frontend.math.subtract(self._ivy_array, delta._ivy_array) + self._ivy_array = ivy.subtract(self._ivy_array, delta._ivy_array) + return self def batch_scatter_update( self, sparse_delta, use_locking=None, name=None, read_value=True