Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a required Neovim version to v0.9.0+ #225

Closed
lewart opened this issue Mar 18, 2024 · 4 comments · Fixed by #223
Closed

Update a required Neovim version to v0.9.0+ #225

lewart opened this issue Mar 18, 2024 · 4 comments · Fixed by #223
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@lewart
Copy link

lewart commented Mar 18, 2024

The README.md file currently states that fidget requires Neovim 0.8.0+, but this is incorrect for versions starting from v0.0.0.

When I try to run a fidget v0.0.0 or newer in a Neovim 0.8.3, it fails with error

Error executing vim.schedule lua callback: vim/shared.lua:0: plain: expected boolean, got table
stack traceback:
        [C]: in function 'error'
        vim/shared.lua: in function 'validate'
        vim/shared.lua: in function 'gsplit'
        ...e/nvim/lazy/fidget.nvim/lua/fidget/notification/view.lua:163: in function 'render_item'

A gsplit function accepts a table type parameter since Neovim 0.9.0.

Please correct a required version in a READMEmd file to v0.9.0+.

P.S.
It would be useful to see an information about changed required Neovim version in release-notes of fidget v0.0.0.

@j-hui j-hui added documentation Improvements or additions to documentation bug Something isn't working labels Mar 20, 2024
@j-hui j-hui closed this as completed in 933db45 Mar 20, 2024
@j-hui
Copy link
Owner

j-hui commented Mar 20, 2024

Oof, thanks for catching that. I should have been more thorough with testing.

It would be useful to see an information about changed required Neovim version in release-notes of fidget v0.0.0.

For this, do you mean backporting this documentation change onto all past versions, and then retagging everything? Or just editing the notes here: https://github.com/j-hui/fidget.nvim/releases

@lewart
Copy link
Author

lewart commented Mar 20, 2024

Thank you for your time!

I meant just editing a release note https://github.com/j-hui/fidget.nvim/releases/tag/v0.0.0.

@j-hui
Copy link
Owner

j-hui commented Mar 20, 2024

No problem! It's fixed.

@lewart
Copy link
Author

lewart commented Mar 20, 2024

Thank You!
Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants