From ac0b13cacb07eb69a5da134f6fff203799349c8f Mon Sep 17 00:00:00 2001 From: Johnson Sun Date: Mon, 26 Aug 2024 01:18:54 +0800 Subject: [PATCH] ci(ros1_bridge_ws): Increase time out minutes Ref: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes --- .github/workflows/build-ros1-bridge-ws.yaml | 1 + tests/lint_workflows.py | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-ros1-bridge-ws.yaml b/.github/workflows/build-ros1-bridge-ws.yaml index 5e2a0554..328887f7 100644 --- a/.github/workflows/build-ros1-bridge-ws.yaml +++ b/.github/workflows/build-ros1-bridge-ws.yaml @@ -14,6 +14,7 @@ jobs: docker: if: github.repository == 'j3soon/ros2-essentials' runs-on: ubuntu-latest + timeout-minutes: 1440 steps: - name: Maximize build space diff --git a/tests/lint_workflows.py b/tests/lint_workflows.py index 36a29285..f73cc735 100644 --- a/tests/lint_workflows.py +++ b/tests/lint_workflows.py @@ -12,5 +12,6 @@ logging.debug(f"Checking: '{filename[len(repo_dir)+1:]}'...") content = Path(filename).read_text() if "master" in content: - # Ref: https://github.com/j3soon/ros2-essentials/pull/44#pullrequestreview-2251404984 - raise ValueError(f"`master` should not exist since it's obsolete: '{filename}'") + if content.count("@master") != content.count("master"): + # Ref: https://github.com/j3soon/ros2-essentials/pull/44#pullrequestreview-2251404984 + raise ValueError(f"`master` should not exist since it's obsolete: '{filename}'")