Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions and Lifecycle Events #35

Open
jackbsteinberg opened this issue Jun 20, 2019 · 0 comments
Open

Transitions and Lifecycle Events #35

jackbsteinberg opened this issue Jun 20, 2019 · 0 comments

Comments

@jackbsteinberg
Copy link
Owner

An issue I can foresee arising from the usage of transitions in showing and hiding toasts is an event firing before the toast transition has completed, (e.g. dispatching the hide event while the toast is still fading off the screen).

A common pattern to fix this was to separate the events show and hide into the lifecycle events willShow, didShow, willHide and didHide, tied to whether or not the transition has completed. Does this pattern give the desired behavior or is it too specific, and should we instead opt to simply dispatch show and hide when the toast is fully shown/hidden or beginning to show/hide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant