-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should infinite durations toasts default to having a close button? #51
Comments
This is an interesting issue. Let me sum up the status quo as of #18:
I see a few options here:
(1) and (2) are both fairly easy. I think I am a bit more comfortable with (1) than (2). (3) is interesting because it really leans on the idea of controlling the closebutton being a stylistic aspect of the element. Kind of like using CSS to control the "x" on |
I like (1) most as a strategy, but I agree that it seems strange to change the As an alternative to avoid this weirdness, we could do nothing - make a recommendation that infinite-duration toasts should have a |
Certainly a toast without an action and a timeout seems like it needs a close button.
The text was updated successfully, but these errors were encountered: