Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling users with "/" in their username #59

Closed
MattyGroch opened this issue Oct 2, 2020 · 3 comments
Closed

Handling users with "/" in their username #59

MattyGroch opened this issue Oct 2, 2020 · 3 comments

Comments

@MattyGroch
Copy link

I just tried using this for the first time but I can't actually run a user-stats because one of the users has "/" in their Slack user name which breaks since filenames cant contain "/". Building the .json for that user in ./build/ is impossible.
@jackellenberger
Copy link
Owner

yeahhh our instance has some users with emoji in their names too so i've been meaning to fix this. Hopefully i'll have some time this weekend unless you want to submit a PR!

@jackellenberger
Copy link
Owner

Just published https://www.npmjs.com/package/emojme/v/1.9.1 let me know if that doesn't help!

@MattyGroch
Copy link
Author

MattyGroch commented Oct 5, 2020 •
edited
Loading

I noticed after I reached out that you already had a mechanism for replacing spaces (safeUserName) so I added a forward slash to that function but you beat me to the PR. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackellenberger @MattyGroch