Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

components(Head): add rss feed to Head #1641

Open
wants to merge 1 commit into
base: v4
Choose a base branch
from

Conversation

vanadium23
Copy link

Closes #1638

@bfahrenfort
Copy link
Contributor

Appreciate you, this exact change was in my to-do list because it was currently hardcoded in my site meta.

Copy link
Collaborator

@saberzero1 saberzero1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for this PR.

Can you please extend the check to ensure RSS has not been disabled in the configuration. (enableRSS).

https://quartz.jzhao.xyz/plugins/ContentIndex

@bfahrenfort
Copy link
Contributor

Hey, thanks for this PR.

Can you please extend the check to ensure RSS has not been disabled in the configuration. (enableRSS).

https://quartz.jzhao.xyz/plugins/ContentIndex

ctx.plugins.emitters.find(e => e.name === "ContentIndex")?.opts.enableRSS ?? false strikes me as overly wordy due to design limitation.

@aarnphm I saw you were looking at plugins, please store them as a dict instead of an array if/when you refactor 🙏

@saberzero1
Copy link
Collaborator

Hey, thanks for this PR.

Can you please extend the check to ensure RSS has not been disabled in the configuration. (enableRSS).

https://quartz.jzhao.xyz/plugins/ContentIndex

ctx.plugins.emitters.find(e => e.name === "ContentIndex")?.opts.enableRSS ?? false strikes me as overly wordy due to design limitation.

@aarnphm I saw you were looking at plugins, please store them as a dict instead of an array if/when you refactor 🙏

Fair. At the same time, if RSS is disabled, the changes in this PR will create a broken link.

Perhaps we should move the configuration option to the quartz.config.ts file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert RSS Feed URL in Head
3 participants