fix: portal fails gracefully if target doesn't exist

jacob-8 · Jul 26, 2024 · 4f87cfe · 4f87cfe
1 parent cb464dc
commit 4f87cfe
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/lib/actions/portal.ts b/src/lib/actions/portal.ts
@@ -2,14 +2,18 @@
  * Usage: `<div use:portal>` or `<div use:portal={'#direction'}>`, add `hidden` if SSR rendered (requires updating action with node.hidden = false and true)
  */
 export function portal(node: HTMLElement, target = 'body') {
-  const portal = document.createElement('div');
-  document.querySelector(target).appendChild(portal);
-  portal.appendChild(node);
+  const target_div = document.querySelector(target)
+  if (!target_div)
+    return
+
+  const portal = document.createElement('div')
+  target_div.appendChild(portal)
+  portal.appendChild(node)
 
   return {
     destroy() {
-      portal.parentElement.removeChild(portal);
+      portal.parentElement.removeChild(portal)
     },
-  };
+  }
 }
 // from https://github.com/romkor/svelte-portal