Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Docker labels should be labels from metadata not tags #775

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[BUGFIX] Docker labels should be labels from metadata not tags #775

wants to merge 1 commit into from

Conversation

halkeye
Copy link

@halkeye halkeye commented Oct 12, 2024 •
edited
Loading

Description

Populate docker labels with the labels generated by docker metadata step, not the tags

Motivation and Context

Renovate and other dependancy updaters don't know where the release notes / changelogs are coming from because they are missing the common opencontainer

How Has This Been Tested?

(Awaiting Build)

Closing issues

Closes #774 774

Checklist:

Go over all the following points, and put an x in all the boxes that apply.
If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • My code follows the code style of this project. (CI will test it anyway and also needs approval)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@halkeye
Copy link
Author

halkeye commented Oct 12, 2024

Had to get a bit creative with the upstream docker.yml action to disable pushing to your dockerhub, but successfully tested

regctl image config --format '{{ jsonPretty .Config.Labels }}' ghcr.io/halkeye/unifi-docker:v0.0.4
{
  "maintainer": "Jacob Alberty <jacob.alberty@foundigital.com>",
  "org.opencontainers.image.created": "2024-10-12T07:44:49.374Z",
  "org.opencontainers.image.description": "Unifi Docker files",
  "org.opencontainers.image.licenses": "MIT",
  "org.opencontainers.image.ref.name": "ubuntu",
  "org.opencontainers.image.revision": "607a8f6c165bc1f9fae16decad07aaaaaf437377",
  "org.opencontainers.image.source": "https://github.com/halkeye/unifi-docker",
  "org.opencontainers.image.title": "unifi-docker",
  "org.opencontainers.image.url": "https://github.com/halkeye/unifi-docker",
  "org.opencontainers.image.version": "v0.0.4"
}

I will also submit a PR that makes pushing to dockerhub conditional on it being this main repo (do you want an issue first?)
and another one that updates the action dependancies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker labels are actually the docker tags
1 participant
@halkeye