Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport to python 2.7 #3

Closed
jadolg opened this issue Mar 21, 2017 · 4 comments
Closed

Backport to python 2.7 #3

jadolg opened this issue Mar 21, 2017 · 4 comments

Comments

@jadolg
Copy link
Owner

jadolg commented Mar 21, 2017

Write modifications to backport this library for python 2.7
@codeshard
Copy link

Not sure, but is not necessary. So far I've tested all users API and there's not any incompatibility with Python 2. Ah! I just added the encoding to the python file, ensuring the encoding 'cause you have some ASCII characters.

@jadolg
Copy link
Owner Author

jadolg commented May 29, 2017

make PR with your changes ;) if it works fine with python2 I'll try building the wheel and upload it to pypi

@ali-mahdavi
Copy link

that's excellent 👍
best regards

@jadolg
Copy link
Owner Author

jadolg commented Sep 29, 2017

I believe it's usable on Python 2, you just have to deal with unicode errors by yourself. I'll close this issue.

@jadolg jadolg closed this as completed Sep 29, 2017
@herronelou herronelou mentioned this issue Jul 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jadolg @codeshard @ali-mahdavi