[jaeger] Add missing loadBalancerIp to collector-svc template. #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indreek
requested review from
davidvonthenen,
naseemkullah and
pavelnikolov
as code owners
|
@indreek could you, please, DCO sign your commits? |
pavelnikolov
approved these changes
May 23, 2023
Signed-off-by: Indrek Kalluste <indrek@kalluste.ee>
Signed-off-by: Indrek Kalluste <indrek@kalluste.ee>
Signed-off-by: Indrek Kalluste <indrek@kalluste.ee>
Signed-off-by: Indrek Kalluste <indrek@kalluste.ee>
Signed-off-by: Indrek Kalluste <indrek@kalluste.ee>
indreek
force-pushed
the
main
branch
2 times, most recently
from
78a8f35
to
dfc15bb
Compare
Signed-off-by: Indrek Kalluste <indrek@kalluste.ee>
|
@pavelnikolov Hey. Will this commit work now? |
Signed-off-by: Pavel Nikolov <pavelnikolov@users.noreply.github.com>
|
Closing this PR due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds missing loadbalancer ip to service
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format,will close that issue when PR gets merged)
Checklist
[jaeger]or[jaeger-operator])